doc: improve ccache explanation#50133
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 15, 2023
Merged
Conversation
ccache improves the build speed significantly only when the branch was built before. Building fresh branches with major changes are not benefited from ccache.
nodejs-github-bot
added
build
anonrig
approved these changes
Oct 11, 2023
anonrig
added
the
author ready
Uzlopak
reviewed
Oct 11, 2023
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
You mean, when we switch between branches that have a common git base, with few differences.
Member
Author
|
@Uzlopak not exactly, it's about if the branch you switching to was built before with cache. Even if there are lots of differences between the branches, if the cache was available, ccache can improve the build speed noticeably. |
aduh95
approved these changes
Oct 13, 2023
targos
approved these changes
Oct 13, 2023
debadree25
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8609915 |
kumarrishav
pushed a commit
to kumarrishav/node
that referenced
this pull request
Oct 16, 2023
ccache improves the build speed significantly only when the branch was built before. Building fresh branches with major changes are not benefited from ccache. PR-URL: nodejs#50133 Fixes: nodejs#49967 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
ccache improves the build speed significantly only when the branch was built before. Building fresh branches with major changes are not benefited from ccache. PR-URL: nodejs#50133 Fixes: nodejs#49967 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
ccache improves the build speed significantly only when the branch was built before. Building fresh branches with major changes are not benefited from ccache. PR-URL: #50133 Fixes: #49967 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ccache improves the build speed significantly only when the branch was
built before. Building fresh branches with major changes are not
benefited from ccache.
Fixes: #49967