-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve code coverage of diagnostics_channel #50053
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
MrJithil:code-coverage-improvement-diagnostics_channel
Oct 19, 2023
Merged
test: improve code coverage of diagnostics_channel #50053
nodejs-github-bot
merged 1 commit into
nodejs:main
from
MrJithil:code-coverage-improvement-diagnostics_channel
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Oct 5, 2023
MrJithil
force-pushed
the
code-coverage-improvement-diagnostics_channel
branch
4 times, most recently
from
October 5, 2023 23:51
3789b15
to
316f34a
Compare
MrJithil
force-pushed
the
code-coverage-improvement-diagnostics_channel
branch
from
October 7, 2023 08:01
316f34a
to
f23b7d2
Compare
Flarna
reviewed
Oct 10, 2023
test/parallel/test-diagnostics-channel-tracing-channel-args-types.js
Outdated
Show resolved
Hide resolved
Flarna
added
diagnostics_channel
Issues and PRs related to diagnostics channel
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Oct 10, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 10, 2023
This comment was marked as outdated.
This comment was marked as outdated.
test: improve code coverage of diagnostics_channel
MrJithil
force-pushed
the
code-coverage-improvement-diagnostics_channel
branch
from
October 10, 2023 12:49
f23b7d2
to
a5b62f8
Compare
@Flarna Please review. |
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 10, 2023
Flarna
approved these changes
Oct 10, 2023
30 tasks
Flarna
approved these changes
Oct 11, 2023
@Flarna please help to re run the C I. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 16, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
added
review wanted
PRs that need reviews.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Oct 16, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 19, 2023
Landed in a8af24b |
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
test: improve code coverage of diagnostics_channel PR-URL: #50053 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
test: improve code coverage of diagnostics_channel PR-URL: nodejs#50053 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
test: improve code coverage of diagnostics_channel PR-URL: #50053 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
diagnostics_channel
Issues and PRs related to diagnostics channel
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: improve code coverage of diagnostics_channel
Current coverage report: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Fdiagnostics_channel.js