fs: improve error performance for ftruncateSync
#50032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
andremralves
force-pushed
the
imprv-ftruncate
branch
from
587e8b4
to
30faa6c
Compare
anonrig
approved these changes
Oct 3, 2023
anonrig
added
performance
|
I think this change probably improves the performance of |
github-actions
bot
removed
the
request-ci
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1439 (queued, will 404 until it starts) |
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50032 ✔ Done loading data for nodejs/node/pull/50032 ----------------------------------- PR info ------------------------------------ Title fs: improve error performance for `ftruncateSync` (#50032) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch andremralves:imprv-ftruncate -> nodejs:main Labels c++, fs, performance, author ready, needs-ci Commits 1 - fs: improve error performance for `ftruncateSync` Committers 1 - Andre Alves PR-URL: https://github.com/nodejs/node/pull/50032 Refs: https://github.com/nodejs/performance/issues/106 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50032 Refs: https://github.com/nodejs/performance/issues/106 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 03 Oct 2023 22:16:05 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50032#pullrequestreview-1656221675 ✘ This PR needs to wait 1 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-03T22:30:22Z: https://ci.nodejs.org/job/node-test-pull-request/54510/ ℹ Last Benchmark CI on 2023-10-06T14:30:20Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1439 - Querying data for job/node-test-pull-request/1439/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6474540635 |
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ed49722 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50032 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50032 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#50032 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/performance#106
cc @nodejs/performance