doc: fix inconsistent styling #4996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
tls
| is not in the root certificates list. (You could provide an issuer via `ca` | ||
| option.) | ||
| NOTE: `issuer` could be `null`, if the certificate is self-signed or if the | ||
| issuer is not in the root certificates list. (You could provide an issuer via |
There was a problem hiding this comment.
Nit, while you're in there: Remove personal pronoun.
Before:
You could provide an issuer via
caoption.
After, something like:
An issuer may be provided via the
caoption.
|
LGTM with a take-it-or-leave-it nit. |
|
LGTM |
|
LGTM with nit addressed |
mscdex
force-pushed
the
doc-tls-fix-styling
branch
from
3bcc34f
to
cad34b3
Compare
|
Wording changed as suggested. |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Feb 4, 2016
PR-URL: #4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 01dd8ed |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
PR-URL: #4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
The changes in this are fairly minor, not landing cleanly, and bringing over other changes. I'm changing to dont-land for now. Please feel free to manually backport or get the conversation going again |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.