lib: fix primordials typings#49895
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 29, 2023
SamVerschueren:fix/primordials-type-definition
Merged
lib: fix primordials typings#49895nodejs-github-bot merged 1 commit intonodejs:mainfrom SamVerschueren:fix/primordials-type-definition
primordials typings#49895nodejs-github-bot merged 1 commit intonodejs:mainfrom
SamVerschueren:fix/primordials-type-definition
Conversation
aduh95
approved these changes
Sep 28, 2023
aduh95
added
the
author ready
MoLow
approved these changes
Sep 28, 2023
MoLow
added
the
commit-queue
atlowChemi
approved these changes
Sep 29, 2023
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1b96975 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49895 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49895 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#49895 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
I noticed that in the
primordials.js, SymbolDispose and SymbolAsyncDispose are defined asThe result of
primordials.SymbolForis asymbol. Currently these two properties are defined asSymbolConstructor(typeof Symbol). I think this is incorrect and should be updated tosymbolinstead.