test: change forEach to for...of#49799
Conversation
Commit Queue failed- Loading data for nodejs/node/pull/49799 ✔ Done loading data for nodejs/node/pull/49799 ----------------------------------- PR info ------------------------------------ Title test: change forEach to for...of (#49799) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tifflastimosa:tl-branch -> nodejs:main Labels test, code-and-learn, author ready, needs-ci Commits 2 - test: change forEach to for...of - Update test/parallel/test-assert.js Committers 2 - tifflastimosa - GitHub PR-URL: https://github.com/nodejs/node/pull/49799 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49799 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 22 Sep 2023 23:56:00 GMT ✔ Approvals: 3 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49799#pullrequestreview-1641043958 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49799#pullrequestreview-1641117127 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/49799#pullrequestreview-1641217111 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-09-29T11:15:32Z: https://ci.nodejs.org/job/node-test-pull-request/54364/ - Querying data for job/node-test-pull-request/54364/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD b903a710f4..0ee9c83ffc main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - b5aacf8028 errors: improve performance of determine-specific-type - 0ee9c83ffc errors: improve performance of determine-specific-type -------------------------------------------------------------------------------- HEAD is now at 0ee9c83ffc errors: improve performance of determine-specific-type ✔ Reset to origin/main - Downloading patch for 49799 From https://github.com/nodejs/node * branch refs/pull/49799/merge -> FETCH_HEAD ✔ Fetched commits as 0ee9c83ffcce..e097d4a79e3c -------------------------------------------------------------------------------- [main 41665b5b90] test: change forEach to for...of Author: tifflastimosa Date: Fri Sep 22 16:08:12 2023 -0700 1 file changed, 6 insertions(+), 9 deletions(-) [main 7e8934c17f] Update test/parallel/test-assert.js Author: Tobias Nießen Date: Sun Sep 24 14:14:16 2023 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/6365784738 |
|
Landed in 42c37f2 |
PR-URL: nodejs#49799 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #49799 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: nodejs#49799 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Changed for each loop to for of loop in test-assert.js