Skip to content

test: replace forEach() with for ... of in test-accessor-properties.js #49773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: replace forEach() with for ... of in test-accessor-properties.js #49773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c79650
test: replace forEach with for ... of
dingbx Sep 22, 2023
f0ae960
Merge branch 'main' into users/yidi/replaceforeach-testaccessorproper…
dingbx Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/parallel/test-accessor-properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const UDP = internalBinding('udp_wrap').UDP;
const StreamWrapProto = Object.getPrototypeOf(TTY.prototype);
const properties = ['bytesRead', 'fd', '_externalStream'];

properties.forEach((property) => {
for (const property of properties) {
// Should throw instead of raise assertions
assert.throws(() => {
TTY.prototype[property]; // eslint-disable-line no-unused-expressions
Expand All @@ -35,7 +35,7 @@ const UDP = internalBinding('udp_wrap').UDP;
'object',
'typeof property descriptor ' + property + ' is not \'object\''
);
});
}

if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
// There are accessor properties in crypto too
Expand Down