Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add primordials strategic initiative #49706

Merged
merged 2 commits into from
Sep 21, 2023
Merged

meta: add primordials strategic initiative #49706

merged 2 commits into from
Sep 21, 2023

Conversation

benjamingr
Copy link
Member

This is a pull request to add the strategic initiative outlined in nodejs/TSC#1439 there is a list of tasks here nodejs/TSC#1439 (comment)

Please do not fast-track this as I'd like to give nodejs/TSC#1439 (comment) a week to make sure everyone had time to see it for lazy consensus

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 18, 2023
@benjamingr benjamingr changed the title Update strategic-initiatives.md meta: add primordials strategic initiative Sep 18, 2023
@benjamingr benjamingr mentioned this pull request Sep 18, 2023
Open
mcollina
mcollina approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tniessen
tniessen approved these changes Sep 19, 2023
View reviewed changes
doc/contributing/strategic-initiatives.md Outdated Show resolved Hide resolved
@benjamingr benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 20, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49706
✔  Done loading data for nodejs/node/pull/49706
----------------------------------- PR info ------------------------------------
Title      meta: add primordials strategic initiative  (#49706)
Author     Benjamin Gruenbaum  (@benjamingr)
Branch     benjamingr:add-primordials-strategic-initiatiive -> nodejs:main
Labels     doc
Commits    2
 - Update strategic-initiatives.md
 - fixup: update link
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49706
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49706
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - fixup: update link
   ℹ  This PR was created on Mon, 18 Sep 2023 17:56:58 GMT
   ✔  Approvals: 6
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631839626
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631852567
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631881734
   ✔  - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632218574
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632662147
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632747668
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6254106051

@benjamingr benjamingr added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49706
✔  Done loading data for nodejs/node/pull/49706
----------------------------------- PR info ------------------------------------
Title      meta: add primordials strategic initiative  (#49706)
Author     Benjamin Gruenbaum  (@benjamingr)
Branch     benjamingr:add-primordials-strategic-initiatiive -> nodejs:main
Labels     doc, commit-queue-squash
Commits    2
 - Update strategic-initiatives.md
 - fixup: update link
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49706
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49706
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 18 Sep 2023 17:56:58 GMT
   ✔  Approvals: 7
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631839626
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631852567
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631881734
   ✔  - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632218574
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632662147
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632747668
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1638400077
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6265913467

@aduh95 aduh95 merged commit 2e4e1e1 into main Sep 21, 2023
27 of 29 checks passed
@aduh95 aduh95 deleted the add-primordials-strategic-initiatiive branch September 21, 2023 19:19
@aduh95
Copy link
Contributor

aduh95 commented Sep 21, 2023

Landed in 2e4e1e1

@anonrig
Copy link
Member

anonrig commented Sep 21, 2023

This broke main

Running JS linter...
Running Markdown linter...
Using release list from env...
doc/contributing/strategic-initiatives.md is not formatted. Please run 'make format-md'.
doc/contributing/strategic-initiatives.md
19:60      warning Cell should be padded                                        table-cell-padding remark-lint
49:1-49:44 warning Unordered reference ("benjamingr" should be before "targos") nodejs-links       remark-lint

⚠ 2 warnings
make: *** [Makefile:1333: tools/.mdlintstamp] Error 1

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@benjamingr @ruyadorno
meta: add primordials strategic initiative
58f7a9e 
PR-URL: #49706
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Closed
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@benjamingr @alexfernandez
meta: add primordials strategic initiative
26b0a00 
PR-URL: nodejs#49706
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
@benjamingr @targos
meta: add primordials strategic initiative
dc70c44 
PR-URL: #49706
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: add primordials strategic initiative
a13036d 
PR-URL: nodejs/node#49706
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: add primordials strategic initiative
9e0d629 
PR-URL: nodejs/node#49706
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung left review comments

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@MoLow MoLow MoLow approved these changes

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

@fhinkel fhinkel fhinkel approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.