Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to npm 2.14.16 #4960

Closed
wants to merge 2 commits into from
Closed

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Jan 29, 2016

Another day, another LTS!

The changelog for this version can be found here: https://github.com/npm/npm/releases/tag/v2.14.16

Interesting changes:

r: @Fishrock123
r: @iarna

@zkat zkat added npm Issues and PRs related to the npm client dependency or the npm registry. lts-watch-v4.x labels Jan 29, 2016
@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/1436/
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/53/

It is worth mentioning the CI does not run make test-npm... but rather makes sure that these changes are not breaking general CI

@zkat
Copy link
Contributor Author

zkat commented Jan 29, 2016

Noted! If you want, npm test-npm should be runnable on non-windows platforms now, but idk what CI plans for this are?

@MylesBorins
Copy link
Contributor

Tests passing locally on OSX 10.10.5

screen shot 2016-01-29 at 2 38 53 pm

@MylesBorins
Copy link
Contributor

I opened an issue nodejs/build#317 to discuss CI plans

@Fishrock123
Copy link
Contributor

make test-npm passes for me, LGTM

@zkat
Copy link
Contributor Author

zkat commented Jan 29, 2016

@Fishrock123 Next release (v2.14.17) will include the patch for pre-releases without cherry-picking btw.

@MylesBorins
Copy link
Contributor

So I went ahead and made a CI job for npm and am doing a test run

I'm expecting failures. To reduce noise I'll post updates in this comment

https://ci.nodejs.org/job/thealphanerd-npm/3/

@Fishrock123
Copy link
Contributor

@zkat this doesn't include that? I didn't modify v4.x-staging at all and it passed.

Edit: can confirm I did indeed build the branch and instal before testing.

@zkat
Copy link
Contributor Author

zkat commented Jan 30, 2016

@Fishrock123 Oh sorry, it wasn't clear: I included it as an extra patch cherry-picked from the last release, because it won't be included in npm itself until next week. See 24b8a5f

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM

PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
zkat added a commit that referenced this pull request Feb 1, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
zkat added a commit that referenced this pull request Feb 1, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

Looks like these commits are on the staging branch. Closing

landed in fcb8cae...9a9ac8e

@MylesBorins MylesBorins closed this Feb 1, 2016
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #4960
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins removed their assignment Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants