esm: fix loading of (recursive) CJS modules from ESM#49500
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 6, 2023
Merged
esm: fix loading of (recursive) CJS modules from ESM#49500nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
esm
github-actions
bot
removed
the
request-ci
Collaborator
25 tasks
Qard
approved these changes
Sep 6, 2023
benjamingr
approved these changes
Sep 6, 2023
Collaborator
aduh95
added
fast-track
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
JakobJingleheimer
approved these changes
Sep 6, 2023
Member
|
Approving fast-track per: node/doc/contributing/collaborator-guide.md Line 186 in d8eb8d0 introduced in 20.6.0 released yesterday |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in fdc65d9 |
20 tasks
This was referenced Sep 7, 2023
1 task
Contributor
|
This is the release schedule (expectation dates) |
Contributor
|
Thank you! It looks like there are only planned dates for the next minor versions there. @UlisesGascon I see that you released 20.6.0 and are working on 20.7.0, maybe you can help here? :) |
Member
|
I'll create the v20.6.1 proposal. But, I won't be able to sign and promote (I'm travelling) - ping @nodejs/releasers. |
RafaelGSS
added a commit
that referenced
this pull request
Sep 7, 2023
Notable changes: esm: * fix loading of CJS modules from ESM (Antoine du Hamel) #49500 PR-URL: TBD
Merged
Member
Member
|
I have bandwidth for it @RafaelGSS @nicolo-ribaudo, I can promote it but I will need first to unblock nodejs/Release#892 🙂 |
26 tasks
24 tasks
1 task
11 tasks
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49500 Fixes: nodejs#49497 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Notable changes: esm: * fix loading of CJS modules from ESM (Antoine du Hamel) nodejs#49500 PR-URL: nodejs#49528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #49497