-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esm: refactor globalPreload
tests
#49493
Closed
GeoffreyBooth
wants to merge
2
commits into
nodejs:main
from
GeoffreyBooth:refactor-globalpreload-tests
Closed
esm: refactor globalPreload
tests
#49493
GeoffreyBooth
wants to merge
2
commits into
nodejs:main
from
GeoffreyBooth:refactor-globalpreload-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyBooth
added
test
Issues and PRs related to the tests.
esm
Issues and PRs related to the ECMAScript Modules implementation.
loaders
Issues and PRs related to ES module loaders
labels
Sep 4, 2023
GeoffreyBooth
force-pushed
the
refactor-globalpreload-tests
branch
from
September 4, 2023 22:34
58636f2
to
dcecdcf
Compare
aduh95
reviewed
Sep 5, 2023
test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs
Outdated
Show resolved
Hide resolved
GeoffreyBooth
force-pushed
the
refactor-globalpreload-tests
branch
2 times, most recently
from
September 5, 2023 18:24
9b0614e
to
cef85dc
Compare
JakobJingleheimer
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
GeoffreyBooth
force-pushed
the
refactor-globalpreload-tests
branch
from
September 5, 2023 20:49
cef85dc
to
7b3dfaf
Compare
GeoffreyBooth
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 5, 2023
aduh95
approved these changes
Sep 5, 2023
aduh95
reviewed
Sep 5, 2023
GeoffreyBooth
force-pushed
the
refactor-globalpreload-tests
branch
from
September 5, 2023 20:56
7b3dfaf
to
e5470e0
Compare
aduh95
approved these changes
Sep 5, 2023
25 tasks
GeoffreyBooth
added
the
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
label
Sep 6, 2023
JakobJingleheimer
added
commit-queue
Add this label to land a pull request using GitHub Actions.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Sep 6, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 6, 2023
Landed in 6b135a1...63c3846 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
PR-URL: #49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
PR-URL: #49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Sep 7, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49493 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49493 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49493 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49493 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backported-to-v18.x
PRs backported to the v18.x-staging branch.
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
esm
Issues and PRs related to the ECMAScript Modules implementation.
loaders
Issues and PRs related to ES module loaders
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #49465 and supporting #49144, this PR refactors two tests that currently use the module customization hook
globalPreload
to use its replacementregister
/initialize
instead. This spins off work from #49144 into a standalone PR so that we have examples to direct people to to show how they can do similar refactors. In that vein, after discussion with @aduh95 we would like to land this PR as two distinct commits, so that we can share either the link to this PR (to cite both tests) or the links to the two commits to reference one refactored test or the other. @nodejs/loaders