test_runner: fix invalid timer call#49477
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Sep 5, 2023
Merged
Conversation
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
rluvaton
reviewed
Sep 3, 2023
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
Member
Author
there's a test but wasn't working as expected. I've changed it to the final impl |
atlowChemi
approved these changes
Sep 4, 2023
atlowChemi
added
experimental
github-actions
bot
removed
the
request-ci
Collaborator
atlowChemi
added
the
author ready
benjamingr
approved these changes
Sep 4, 2023
MoLow
approved these changes
Sep 4, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
ErickWendel
added
the
commit-queue
19 tasks
ErickWendel
added
the
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a61bc9d |
This was referenced Sep 6, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: #49477 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Closed
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs#49477 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: #49477 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs/node#49477 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs/node#49477 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix missing call to reset node timer call