tls: refactor to use validateFunction #49422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use validateFunction to remove duplicate implementation. Plus, remove `assert()` statement because validateFunction has the same purpose.
nodejs-github-bot
added
needs-ci
VoltrexKeyva
approved these changes
Aug 31, 2023
github-actions
bot
removed
the
request-ci
debadree25
approved these changes
Sep 1, 2023
debadree25
added
author ready
lpinca
approved these changes
Sep 1, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0add7a8 |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Use validateFunction to remove duplicate implementation. Plus, remove `assert()` statement because validateFunction has the same purpose. PR-URL: #49422 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Use validateFunction to remove duplicate implementation. Plus, remove `assert()` statement because validateFunction has the same purpose. PR-URL: nodejs#49422 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use validateFunction to remove duplicate implementation. Plus, remove
assert()statement because validateFunction has the same purpose.