Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not rely on the internal field being default to undefined #49413

Merged
merged 1 commit into from
Sep 7, 2023
Merged

src: do not rely on the internal field being default to undefined #49413

merged 1 commit into from
Sep 7, 2023

Commits on Aug 26, 2023

  1. src: do not rely on the internal field being default to undefined 

    It's an undocumented V8 behavior that is subject to change. Instead
just check if the internal field is set to a promise. There is also
no need to check IsEmpty() since the object is guaranteed to be
constructed by the FileHandle constructor with enough internal
fields.
    @joyeecheung
    joyeecheung committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    7fc751d View commit details
    Browse the repository at this point in the history