Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a segfault by ensuring TLS Sockets are closed if the underlying stream closes #49327

Merged
merged 2 commits into from
Sep 1, 2023

Commits on Aug 25, 2023

  1. tls: ensure TLS Sockets are closed if the underlying wrap closes

    This fixes a potential segfault, among various other likely-related
    issues, which all occur because TLSSockets were not informed if their
    underlying stream was closed in many cases.
    
    This also significantly modifies an existing TLS test. With this change
    in place, that test no longer works, as it tries to mess with internals
    to trigger a race, and those internals are now cleaned up earlier. This
    test has been simplified to a more general TLS shutdown test.
    pimterry committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    06fc079 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Tweak new H2 shutdown test towards reliable ordering & client shutdown

    Currently the test fails only in a couple of environments (Mac & ASan)
    reliably, even though it passes reliably in all others. The failures are
    due to emitted errors on the client H2 stream (not the focus of this
    test). I'm hoping here that that's due to a timing different in those
    environments, and scheduling the shutdown like this instead will
    guarantee the order so that doesn't happen any more.
    pimterry committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    87ceb7e View commit details
    Browse the repository at this point in the history