doc: use cjs as block code's type in MockTimers
#49309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `cjs` instead of `js` to show toggle button between CJS and ESM because corresponding example using `mjs` exists.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
GeoffreyBooth
requested changes
Aug 24, 2023
Member
GeoffreyBooth
left a comment
GeoffreyBooth
left a comment
There was a problem hiding this comment.
You need to add the ESM version too, in a block just after the cjs version.
GeoffreyBooth
approved these changes
Aug 24, 2023
Member
GeoffreyBooth
left a comment
GeoffreyBooth
left a comment
There was a problem hiding this comment.
Whoops sorry I was looking after the cjs block not before.
aduh95
approved these changes
Aug 24, 2023
aduh95
added
author ready
atlowChemi
approved these changes
Aug 24, 2023
rluvaton
approved these changes
Aug 25, 2023
lpinca
approved these changes
Aug 25, 2023
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in fee0601 |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Use `cjs` instead of `js` to show toggle button between CJS and ESM because corresponding example using `mjs` exists. PR-URL: #49309 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Use `cjs` instead of `js` to show toggle button between CJS and ESM because corresponding example using `mjs` exists. PR-URL: nodejs#49309 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Use `cjs` instead of `js` to show toggle button between CJS and ESM because corresponding example using `mjs` exists. PR-URL: #49309 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Use `cjs` instead of `js` to show toggle button between CJS and ESM because corresponding example using `mjs` exists. PR-URL: nodejs/node#49309 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Use `cjs` instead of `js` to show toggle button between CJS and ESM because corresponding example using `mjs` exists. PR-URL: nodejs/node#49309 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
cjsinstead ofjsto show toggle button between CJS and ESM because corresponding example usingmjsexists.