Merged
Conversation
nodejs-github-bot
added
doc
tniessen
reviewed
Aug 22, 2023
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
This seems extremely long and verbose for a rather simple statement. The documentation already says that the function will be applied to files and directories.
aduh95
approved these changes
Aug 23, 2023
aduh95
added
the
author ready
tniessen
approved these changes
Aug 23, 2023
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Nit: commit message does not adhere to the commit message guidelines
shubham9411
force-pushed
the
updating-fs-filter-doc
branch
from
7a4107b to
7898fe0
Compare
aymen94
approved these changes
Aug 23, 2023
lpinca
approved these changes
Aug 23, 2023
LiviaMedeiros
approved these changes
Aug 24, 2023
Member
|
The commit message guidelines suggest that it should start with an imperative verb, so maybe something like
or
Would be slightly better. |
Contributor
Author
|
@LiviaMedeiros yes, I had updated first commit to |
Contributor
|
Landed in 4178683, thanks for the contribution :) |
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49289 Fixes: nodejs#49092 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49289 Fixes: nodejs/node#49092 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49289 Fixes: nodejs/node#49092 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating doc for
fs.cp,fsPromises.cpandfs.cpSync.Added the caveat that filter will be applied to both files and dirs.
Fixes: #49092