doc: add signature for module.register#49251
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Aug 20, 2023
Merged
Conversation
GeoffreyBooth
added
doc
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
module
GeoffreyBooth
force-pushed
the
register-docs
branch
from
80a1649 to
a3f9fc7
Compare
aduh95
reviewed
Aug 20, 2023
aduh95
reviewed
Aug 20, 2023
aduh95
reviewed
Aug 20, 2023
GeoffreyBooth
force-pushed
the
register-docs
branch
2 times, most recently
from
912b03f to
5ec4fd3
Compare
GeoffreyBooth
added
the
fast-track
Contributor
|
Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve. |
anonrig
approved these changes
Aug 20, 2023
Collaborator
GeoffreyBooth
force-pushed
the
register-docs
branch
from
5ec4fd3 to
a48dffc
Compare
Collaborator
Collaborator
aduh95
reviewed
Aug 20, 2023
aduh95
reviewed
Aug 20, 2023
Contributor
|
The commit message subsystem should be |
JakobJingleheimer
approved these changes
Aug 20, 2023
GeoffreyBooth
changed the title
registermodule.register
GeoffreyBooth
force-pushed
the
register-docs
branch
from
a48dffc to
76c719d
Compare
aduh95
approved these changes
Aug 20, 2023
GeoffreyBooth
force-pushed
the
register-docs
branch
from
76c719d to
367861e
Compare
aduh95
approved these changes
Aug 20, 2023
anonrig
approved these changes
Aug 20, 2023
GeoffreyBooth
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 484ad83 |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #49251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49251 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49251 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the recent PRs that created
register, we neglected to define its signature. @nodejs/loaders