Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add signature for module.register #49251

Merged
merged 1 commit into from
Aug 20, 2023
Merged

doc: add signature for module.register #49251

merged 1 commit into from
Aug 20, 2023

Conversation

GeoffreyBooth
Copy link
Member

In the recent PRs that created register, we neglected to define its signature. @nodejs/loaders

@GeoffreyBooth GeoffreyBooth added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels Aug 20, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the module Issues and PRs related to the module subsystem. label Aug 20, 2023
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
doc/api/module.md Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
doc/api/module.md Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
doc/api/module.md Outdated Show resolved Hide resolved
doc/api/module.md Outdated Show resolved Hide resolved
doc/api/module.md Outdated Show resolved Hide resolved
doc/api/module.md Outdated Show resolved Hide resolved
doc/api/module.md Outdated Show resolved Hide resolved
@GeoffreyBooth GeoffreyBooth force-pushed the register-docs branch 2 times, most recently from 912b03f to 5ec4fd3 Compare August 20, 2023 00:23
@GeoffreyBooth GeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 20, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53452/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53455/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53459/

aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
doc/api/module.md Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Aug 20, 2023
View reviewed changes
doc/api/module.md Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented Aug 20, 2023

The commit message subsystem should be doc:, not module:. Also FYI there is no need to run Jenkins CI for doc PRs.

@GeoffreyBooth GeoffreyBooth changed the title module: add docs signature for register doc: add signature for module.register Aug 20, 2023
@GeoffreyBooth GeoffreyBooth added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2023
@nodejs-github-bot nodejs-github-bot merged commit 484ad83 into nodejs:main Aug 20, 2023
17 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 484ad83

@GeoffreyBooth GeoffreyBooth deleted the register-docs branch August 20, 2023 20:55
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@GeoffreyBooth @UlisesGascon
doc: add signature for module.register
1704f24 
PR-URL: #49251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@GeoffreyBooth @targos
doc: add signature for module.register
0b72534 
PR-URL: nodejs#49251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@GeoffreyBooth @targos
doc: add signature for module.register
258df0e 
PR-URL: #49251
Backport-PR-URL: #50669
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add signature for module.register
b27eef3 
PR-URL: nodejs/node#49251
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: add signature for module.register
3ef713f 
PR-URL: nodejs/node#49251
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@aduh95 aduh95 aduh95 approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@GeoffreyBooth @nodejs-github-bot @aduh95 @ljharb @anonrig @JakobJingleheimer @targos