-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix assertion message in test_async.c #49146
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:test-node-api-test-async-assert-3
Aug 15, 2023
Merged
test: fix assertion message in test_async.c #49146
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:test-node-api-test-async-assert-3
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast-track has been requested by @tniessen. Please 👍 to approve. |
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
node-api
Issues and PRs related to the Node-API.
test
Issues and PRs related to the tests.
labels
Aug 13, 2023
MoLow
approved these changes
Aug 14, 2023
lpinca
approved these changes
Aug 14, 2023
tniessen
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Aug 14, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 14, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
22 tasks
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 15, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 15, 2023
Landed in 115f801 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
PR-URL: #49146 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#49146 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rluvaton
pushed a commit
to rluvaton/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#49146 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
24 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 16, 2023
PR-URL: #49146 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
26 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 17, 2023
PR-URL: #49146 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
node-api
Issues and PRs related to the Node-API.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.