Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] build, deps, test, tools: avoid excessive LTO, debug information #49065

Open
wants to merge 3 commits into
base: v18.x
Choose a base branch
from
Open

[v18.x backport] build, deps, test, tools: avoid excessive LTO, debug information #49065

wants to merge 3 commits into from

Conversation

rockdrilla
Copy link
Contributor

This PR is backport of #49063 for "v18.x" branch.

Signed-off-by: Konstantin Demin rockdrilla@gmail.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Aug 8, 2023
@rockdrilla rockdrilla force-pushed the build-flags-v18.x branch 3 times, most recently from b8c1210 to 6c1f5e8 Compare August 8, 2023 06:53
@rockdrilla rockdrilla marked this pull request as draft August 8, 2023 09:55
@rockdrilla rockdrilla marked this pull request as ready for review September 16, 2023 19:23
@rockdrilla rockdrilla changed the title [v18.x] build, deps, tools: avoid excessive LTO, PGO, debug information [v18.x] build, deps, tools: avoid excessive LTO, debug information Sep 16, 2023
@rockdrilla rockdrilla changed the title [v18.x] build, deps, tools: avoid excessive LTO, debug information [v18.x] build, deps, test, tools: avoid excessive LTO, debug information Sep 16, 2023
@rockdrilla rockdrilla mentioned this pull request Sep 16, 2023
Merged
@rockdrilla
build, deps, test: avoid excessive LTO
0126959 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@rockdrilla
tools: remove non-working condition
79bee32 
condition doesn't apply to this target type (introduced in db910dd)

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@rockdrilla
build, tools: avoid extra debug information
a4e7542 
Don't build intermediate executables with debug information in order
to save some disk space during build.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@ruyadorno
Copy link
Member

@mhdawson can you review these changes? (or cc someone that is able to)

@targos targos added the blocked PRs that are blocked by other issues or PRs. label Nov 10, 2023
@aduh95 aduh95 changed the title [v18.x] build, deps, test, tools: avoid excessive LTO, debug information [v18.x backport] build, deps, test, tools: avoid excessive LTO, debug information Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rockdrilla @nodejs-github-bot @ruyadorno @targos