benchmark: add benchmarks for the test_runner#48931
benchmark: add benchmarks for the test_runner#48931nodejs-github-bot merged 9 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
benchmark
| }); | ||
| } | ||
|
|
||
| await Promise.all(promises); |
There was a problem hiding this comment.
Should we use finished on the reporter or this?
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
I mostly didn't understand what we are benchmarking. Can you leave some descriptive comments on what we are benchmarking? PS: The file names does not help either. (For example: plain-tests-as-fast-as-can)
we want to compare how changes in test runner code affect its performance, but I agree naming can be improved @rluvaton in regarding to #47945 (comment) - @cjihrig and myself were talking about what we want to benchmark - we probably also want to run tests with |
I don't think running the test-runner fixture folder is a good idea as it changes, while I think benchmarks are best when they are static
I avoided that on purpose to reduce the scope of the benchmark, adding the |
it is ok since the benchmarks are compared before and after a change we want to understand the impact of. no baseline or benchmark is saved according to @cjihrig
that is a good point, but I think that should only mean we should rely on this specific benchmark only if it is significantly different, not that we shouldn't test it at all |
I prefer if you add those as you also need to add |
debadree25
added
author ready
debadree25
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f458e5b |
PR-URL: nodejs#48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: nodejs#48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: nodejs#48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: nodejs#48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: nodejs#48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: #48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: nodejs#48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: #48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: #48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: nodejs/node#48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: nodejs/node#48931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
7 participants
I'm trying to benchmark tests creation and execution
this is needed as we need to evaluate how a change in the test runner affects the performance: