Skip to content

lib: fix lib/internal/blob.js Blob.stream() for #48668 #48916#48930

Closed
bellbind wants to merge 2 commits intonodejs:mainfrom
bellbind:fix-lib-internal-blob
Closed

lib: fix lib/internal/blob.js Blob.stream() for #48668 #48916#48930
bellbind wants to merge 2 commits intonodejs:mainfrom
bellbind:fix-lib-internal-blob

Conversation

@bellbind
Copy link
Contributor

Add lacked calling resolve() for finish ReadableStream.pull().

Fixes: #48668
Fixes: #48916
Fixes: #48232
Refs: 8cc1438

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 26, 2023
…8916

Add lacked calling resolve() for finish ReadableStream source.pull().

Fixes: nodejs#48668
Fixes: nodejs#48916
Fixes: nodejs#48232
Refs: 8cc1438
@bellbind
Copy link
Contributor Author

bellbind commented Jul 27, 2023

Reopened to fix the first commit message failure at: #48935

@daeyeon
Copy link
Member

daeyeon commented Jul 30, 2023

Closing in favor of #48935

@daeyeon daeyeon closed this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blob.stream().pipeTo() never resolves Awaiting a Promise between creating a stream and consuming a stream causes Node to crash with code 13

3 participants