Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: fix isURL detection by checking path #48928

Closed
wants to merge 1 commit into from
Closed

url: fix isURL detection by checking path #48928

wants to merge 1 commit into from

Conversation

Zhangdroid
Copy link
Contributor

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jul 26, 2023
* WHATWG URL instance.
* @param {*} self
* @returns {self is URL}
*/
function isURL(self) {
return Boolean(self?.href && self.protocol && self.auth === undefined);
return Boolean(self?.href && self.protocol && self.auth === undefined && self.path === undefined);
Copy link
Contributor Author

@Zhangdroid Zhangdroid Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I don't think this is the ideal way to fix the issue #48921 , but since path is an attribute in legacy URL object instance, and another issue has been fixed in same way: #47886 I think this fix maybe fine. If you have a better way, please let me know.

@anonrig anonrig requested a review from aduh95 July 26, 2023 13:59
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is sort of like a chicken in the egg problem. We can't properly check for URL and we can't properly check for url. The only thing we can do is check their behavior/definition. I'm fine with merging this but, I'm afraid there will be some other edge case that we didn't cover.

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v18.x PRs that may need to be released in v18.x. and removed lts-watch-v18.x PRs that may need to be released in v18.x. labels Jul 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48928
✔  Done loading data for nodejs/node/pull/48928
----------------------------------- PR info ------------------------------------
Title      url: fix `isURL` detection by checking `path` (#48928)
Author     Zhuo Zhang  (@Zhangdroid, first-time contributor)
Branch     Zhangdroid:zhuo/fix-is-url -> nodejs:main
Labels     whatwg-url, author ready, needs-ci
Commits    1
 - url: fix `isURL` detection by checking `path`
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48928
Fixes: https://github.com/nodejs/node/issues/48921
Fixes: https://github.com/getsentry/sentry-javascript/issues/8552
Fixes: https://github.com/request/request/issues/3458
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matthew Aitken 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48928
Fixes: https://github.com/nodejs/node/issues/48921
Fixes: https://github.com/getsentry/sentry-javascript/issues/8552
Fixes: https://github.com/request/request/issues/3458
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matthew Aitken 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 26 Jul 2023 04:01:57 GMT
   ✔  Approvals: 3
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/48928#pullrequestreview-1547810927
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48928#pullrequestreview-1548415285
   ✔  - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/48928#pullrequestreview-1551214741
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-07-26T22:07:24Z: https://ci.nodejs.org/job/node-test-pull-request/52947/
- Querying data for job/node-test-pull-request/52947/
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @Zhangdroid(i@zhuo.dev)
   ⚠  - commit 333fa8eaa787 is authored by contrary.zhuo@gmail.com
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5688124610

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 28, 2023
@Zhangdroid
Copy link
Contributor Author

Hi @anonrig, I saw the bot tried to merge this PR but failed, it might because I use two emails, can you help to merge this?

@debadree25 debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 29, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48928
✔  Done loading data for nodejs/node/pull/48928
----------------------------------- PR info ------------------------------------
Title      url: fix `isURL` detection by checking `path` (#48928)
Author     Zhuo Zhang  (@Zhangdroid, first-time contributor)
Branch     Zhangdroid:zhuo/fix-is-url -> nodejs:main
Labels     whatwg-url, author ready, needs-ci
Commits    1
 - url: fix `isURL` detection by checking `path`
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48928
Fixes: https://github.com/nodejs/node/issues/48921
Fixes: https://github.com/getsentry/sentry-javascript/issues/8552
Fixes: https://github.com/request/request/issues/3458
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matthew Aitken 
Reviewed-By: Debadree Chatterjee 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48928
Fixes: https://github.com/nodejs/node/issues/48921
Fixes: https://github.com/getsentry/sentry-javascript/issues/8552
Fixes: https://github.com/request/request/issues/3458
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matthew Aitken 
Reviewed-By: Debadree Chatterjee 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 26 Jul 2023 04:01:57 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/48928#pullrequestreview-1547810927
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48928#pullrequestreview-1548415285
   ✔  - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/48928#pullrequestreview-1551214741
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48928#pullrequestreview-1553347070
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-07-28T04:14:43Z: https://ci.nodejs.org/job/node-test-pull-request/52947/
- Querying data for job/node-test-pull-request/52947/
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @Zhangdroid(i@zhuo.dev)
   ⚠  - commit 333fa8eaa787 is authored by contrary.zhuo@gmail.com
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5701754486

debadree25 pushed a commit that referenced this pull request Jul 29, 2023
Fixes: #48921
PR-URL: #48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@debadree25
Copy link
Member

Landed in d7ed3a4

@debadree25 debadree25 closed this Jul 29, 2023
@debadree25
Copy link
Member

Thank you for your contribution 🥳 @Zhangdroid

@debadree25 debadree25 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 29, 2023
@Apollon77
Copy link

I known in which node-js version this fix will be included?

pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Aug 8, 2023

I known in which node-js version this fix will be included?

As usual for semver-patch changes, it should be included in the next (non-security) release of the Current Line (which is 20.x at the time of writing), and once it has been on a Current Line for at least two weeks, it should be backported to the next non-security release of the Active LTS line (which is 18.x at the time of writing).

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
Fixes: #48921
PR-URL: #48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
Fixes: #48921
PR-URL: #48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@aduh95 aduh95 mentioned this pull request Aug 18, 2023
@ruyadorno
Copy link
Member

This commit is not landing cleanly on v18.x-staging and will need manual backport if we want this to land on v18.x.

@ruyadorno ruyadorno added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Sep 8, 2023
aduh95 pushed a commit to aduh95/node that referenced this pull request Oct 9, 2023
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
Fixes: #48921
PR-URL: #48928
Backport-PR-URL: #50105
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Fixes: nodejs/node#48921
PR-URL: nodejs/node#48928
Backport-PR-URL: nodejs/node#50105
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Fixes: nodejs/node#48921
PR-URL: nodejs/node#48928
Backport-PR-URL: nodejs/node#50105
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
9 participants