Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix second parameter name of events.addAbortListener #48922

Merged
merged 1 commit into from
Jul 27, 2023
Merged

doc: fix second parameter name of events.addAbortListener #48922

merged 1 commit into from
Jul 27, 2023

Conversation

deokjinkim
Copy link
Contributor

Second parameter name is described as listener(not resource) in below line.

@deokjinkim
doc: fix second parameter name of events.addAbortListener
f2489ab 
Second parameter name is described as `listener`(not resource)
in below line.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Jul 25, 2023
@deokjinkim deokjinkim marked this pull request as ready for review July 25, 2023 15:06
@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit 761f568 into nodejs:main Jul 27, 2023
39 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 761f568

rluvaton pushed a commit to rluvaton/node that referenced this pull request Jul 28, 2023
@deokjinkim @rluvaton
doc: fix second parameter name of events.addAbortListener
3ee7bf7 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: nodejs#48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@deokjinkim
doc: fix second parameter name of events.addAbortListener
c16087d 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: nodejs#48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@deokjinkim
doc: fix second parameter name of events.addAbortListener
f134ab7 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: nodejs#48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@deokjinkim @Ceres6
doc: fix second parameter name of events.addAbortListener
c8c76a4 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: nodejs#48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@deokjinkim @Ceres6
doc: fix second parameter name of events.addAbortListener
149fc6a 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: nodejs#48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@deokjinkim @UlisesGascon
doc: fix second parameter name of events.addAbortListener
e55ca2d 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: nodejs#48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@deokjinkim @RafaelGSS
doc: fix second parameter name of events.addAbortListener
12f6981 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: #48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@deokjinkim @RafaelGSS
doc: fix second parameter name of events.addAbortListener
0db104a 
Second parameter name is described as `listener`(not resource)
in below line.

PR-URL: #48922
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@trivikr trivikr trivikr approved these changes

@aymen94 aymen94 aymen94 approved these changes

@MoLow MoLow MoLow approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@deokjinkim @nodejs-github-bot @lpinca @tniessen @MoLow @aymen94 @trivikr @marsonya