Skip to content

process: trace sync api - #48857

Closed
theanarkh wants to merge 1 commit into
nodejs:mainfrom
theanarkh:trace_process_spawn_sync
Closed

process: trace sync api#48857
theanarkh wants to merge 1 commit into
nodejs:mainfrom
theanarkh:trace_process_spawn_sync

Conversation

@theanarkh

Copy link
Copy Markdown
Contributor

trace process sync APIs. The example is as follows.

execFileSync('node', ['-e', 'setTimeout(() => {}, 5000)']);
image
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jul 20, 2023
@gengjiawen

Copy link
Copy Markdown
Member

Not sure this triggered coverage failure, cc @bcoe

@gengjiawen

Copy link
Copy Markdown
Member

@nodejs/coverage-admins This is likely a false positive, any idea to fix this ?

@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@theanarkh
theanarkh force-pushed the trace_process_spawn_sync branch from 14315c7 to 145a4ec Compare October 7, 2023 12:22
@theanarkh
theanarkh force-pushed the trace_process_spawn_sync branch from 145a4ec to 1fc5a98 Compare November 7, 2023 18:19
@theanarkh

Copy link
Copy Markdown
Contributor Author

@jasnell Hi jasnell, Do you know why coverage checks fail, I haven't seen in other PR 🤔️。

@theanarkh
theanarkh force-pushed the trace_process_spawn_sync branch from 1fc5a98 to 9ce152b Compare November 23, 2023 14:15
@theanarkh theanarkh closed this Nov 23, 2023
@theanarkh theanarkh reopened this Nov 25, 2023
@theanarkh
theanarkh force-pushed the trace_process_spawn_sync branch from 9ce152b to 3f69a63 Compare February 22, 2024 16:33
@aduh95
aduh95 force-pushed the trace_process_spawn_sync branch from 3f69a63 to 2b662d9 Compare May 11, 2024 14:14
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale label Jul 28, 2026
@avivkeller avivkeller closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants