Open
Conversation
Member
|
Not sure this triggered coverage failure, cc @bcoe |
Member
|
@nodejs/coverage-admins This is likely a false positive, any idea to fix this ? |
Collaborator
047289b to
14315c7
Compare
This was referenced Jul 26, 2023
jasnell
approved these changes
Sep 14, 2023
14315c7 to
145a4ec
Compare
jasnell
approved these changes
Oct 28, 2023
145a4ec to
1fc5a98
Compare
Contributor
Author
|
@jasnell Hi jasnell, Do you know why coverage checks fail, I haven't seen in other PR 🤔️。 |
1fc5a98 to
9ce152b
Compare
9ce152b to
3f69a63
Compare
3f69a63 to
2b662d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trace process sync APIs. The example is as follows.
make -j4 test(UNIX), orvcbuild test(Windows) passes