Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix async callback in describe not awaited #48856

Merged
merged 6 commits into from
Jul 23, 2023
Merged

test_runner: fix async callback in describe not awaited #48856

merged 6 commits into from
Jul 23, 2023

Conversation

rluvaton
Copy link
Member

fix #48845

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jul 20, 2023
MoLow
MoLow approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52881/

@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 21, 2023
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 44b8a06 into nodejs:main Jul 23, 2023
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 44b8a06

@rluvaton rluvaton deleted the fix/async-callback-in-describe-not-awaited branch July 23, 2023 10:31
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@rluvaton @Ceres6
test_runner: fix async callback in describe not awaited
697974b 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@rluvaton
test_runner: fix async callback in describe not awaited
3a68c4b 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@rluvaton
test_runner: fix async callback in describe not awaited
045e16f 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test_runner: fix async callback in describe not awaited
ecee4c4 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test_runner: fix async callback in describe not awaited
2932125 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@rluvaton @UlisesGascon
test_runner: fix async callback in describe not awaited
6dae4f7 
PR-URL: nodejs#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@rluvaton @RafaelGSS
test_runner: fix async callback in describe not awaited
65d2394 
PR-URL: #48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
@atlowChemi atlowChemi mentioned this pull request Sep 30, 2023
Closed
targos pushed a commit that referenced this pull request Oct 28, 2023
@rluvaton @targos
test_runner: fix async callback in describe not awaited
6b186d4 
PR-URL: #48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix async callback in describe not awaited
0ae24b6 
PR-URL: nodejs/node#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix async callback in describe not awaited
f2b9368 
PR-URL: nodejs/node#48856
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test runner: async callbacks passed to describe are note awaited
5 participants
@rluvaton @nodejs-github-bot @MoLow @atlowChemi @lpinca