Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] test_runner: add shards support #48797

Closed
wants to merge 1 commit into from
Closed

[v20.x backport] test_runner: add shards support #48797

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 16, 2023

backport of #48639
supersedes #48768

@rluvaton @MoLow
test_runner: add shards support
61c9ba1 
PR-URL: nodejs#48639
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jul 16, 2023
@MoLow MoLow requested a review from juanarbol July 16, 2023 06:57
@rluvaton
Copy link
Member

Does this PR need to wait for 48 hours as well? what are the guidelines?

@MoLow
Copy link
Member Author

MoLow commented Jul 16, 2023

see https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md for more context.
AFAIK, @nodejs/releasers can land backport prs without waiting for 48 hours

@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52799/

juanarbol
juanarbol approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thanks.

@juanarbol
Copy link
Member

see https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md for more context. AFAIK, @nodejs/releasers can land backport prs without waiting for 48 hours

Yeap, people want this on v20.x, I'm going to release that if CI is happy with it 🎉

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52802/

@rluvaton
Copy link
Member

rluvaton commented Jul 17, 2023 •
edited
Loading

Thank you @MoLow for all your help
And @juanarbol, Thank you for your hard work!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52804/

@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Open
26 tasks
@MoLow MoLow mentioned this pull request Jul 18, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jul 18, 2023
@rluvaton @juanarbol
test_runner: add shards support
0ef73ff 
PR-URL: #48639
Backport-PR-URL: #48797
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@juanarbol
Copy link
Member

Landed in 0ef73ff

@juanarbol juanarbol closed this Jul 18, 2023
This was referenced Jul 19, 2023
Open
Open
Open
Open
@MoLow MoLow deleted the backport-sharding branch August 15, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@juanarbol juanarbol juanarbol approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. test_runner Issues and PRs related to the test runner subsystem. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MoLow @nodejs-github-bot @rluvaton @juanarbol @benjamingr @atlowChemi @aduh95