-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: refactor node-api support matrix #48774
Conversation
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: nodejs#48277 Signed-off-by: Michael Dawson <mdawson@devrus.com>
Review requested:
|
Commit Queue failed- Loading data for nodejs/node/pull/48774 ✔ Done loading data for nodejs/node/pull/48774 ----------------------------------- PR info ------------------------------------ Title doc: refactor node-api support matrix (#48774) Author Michael Dawson (@mhdawson) Branch mhdawson:node-api-matrix -> nodejs:main Labels doc, node-api Commits 2 - doc: refactor node-api support matrix - Update doc/api/n-api.md Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/48774 Refs: https://github.com/nodejs/node/issues/48277 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48774 Refs: https://github.com/nodejs/node/issues/48277 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Jul 2023 18:27:39 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48774#pullrequestreview-1530886074 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48774#pullrequestreview-1531316690 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48774 From https://github.com/nodejs/node * branch refs/pull/48774/merge -> FETCH_HEAD ✔ Fetched commits as 51513b23e88c..dcb5d42ab059 -------------------------------------------------------------------------------- [main 3bfbcfc40c] doc: refactor node-api support matrix Author: Michael Dawson Date: Fri Jul 14 14:16:16 2023 -0400 1 file changed, 25 insertions(+), 77 deletions(-) [main bea5b1dbb1] Update doc/api/n-api.md Author: Michael Dawson Date: Fri Jul 14 14:30:12 2023 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)
Refs: #48277 Signed-off-by: Michael Dawson mdawson@devrus.com
|
Landed in 38cc538 |
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: nodejs#48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: nodejs#48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: nodejs#48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: nodejs#48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: nodejs#48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: #48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: #48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: nodejs/node#48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- refactor table so that it does not grow for every new version of Node.js - refer to latest version of table as the canonical reference - add info for Node-API v9 Refs: nodejs/node#48277 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#48774 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: #48277