Skip to content

test: do not use test patterns in sharding tests#48768

Closed
rluvaton wants to merge 4 commits intonodejs:mainfrom
rluvaton:backport-shards-in-testing
Closed

test: do not use test patterns in sharding tests#48768
rluvaton wants to merge 4 commits intonodejs:mainfrom
rluvaton:backport-shards-in-testing

Conversation

@rluvaton
Copy link
Member

@rluvaton rluvaton commented Jul 14, 2023

Do not use test files glob patterns in test runner sharding tests so the sharding can be backported to version 20:

Cc @juanarbol, @MoLow

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 14, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 14, 2023
atlowChemi
atlowChemi reviewed Jul 14, 2023
View reviewed changes
atlowChemi
atlowChemi reviewed Jul 14, 2023
View reviewed changes
atlowChemi
atlowChemi reviewed Jul 14, 2023
View reviewed changes
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52772/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52773/

@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 16, 2023
MoLow
MoLow requested changes Jul 16, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't really need this fix for the main branch so I'd prefer if we just create a backport PR with this fix applied on top of 9988130
this PR by itself won't make #48619 land clearly

@MoLow MoLow removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 16, 2023
@MoLow MoLow mentioned this pull request Jul 16, 2023
Closed
@rluvaton
Copy link
Member Author

rluvaton commented Jul 16, 2023

Thanks!

@rluvaton rluvaton closed this Jul 16, 2023
@rluvaton rluvaton deleted the backport-shards-in-testing branch July 16, 2023 07:28
This was referenced Jul 16, 2023
Open
Open
This was referenced Jul 18, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow requested changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rluvaton @nodejs-github-bot @benjamingr @lpinca @anonrig @MoLow @atlowChemi