Skip to content

tools: run fetch_deps.py with Python 3 #48729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

tools: run fetch_deps.py with Python 3 #48729

merged 1 commit into from
Jul 12, 2023

Conversation

richardlau
Copy link
Member

Python 3 is now required to run gclient. Run tools/v8/fetch_deps.py, which spawns glient, with Python 3.

Fixes: #48728

cc @nodejs/v8-update

@richardlau
tools: run fetch_deps.py with Python 3
55c6d6c 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 10, 2023
@richardlau richardlau mentioned this pull request Jul 10, 2023
Closed
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 10, 2023
@debadree25
Copy link
Member

probably can be fast tracked? adding fastrack label

@debadree25 debadree25 added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 10, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @debadree25. Please 👍 to approve.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5449/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5449/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5449/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5451/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5451/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5451/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5452/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5452/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5452/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6a1316d into nodejs:main Jul 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 6a1316d

@richardlau richardlau deleted the v8fetchdeps branch July 12, 2023 14:47
@richardlau richardlau mentioned this pull request Jul 12, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
@richardlau @juanarbol
tools: run fetch_deps.py with Python 3
4398ade 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@juanarbol juanarbol mentioned this pull request Jul 13, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@richardlau @Ceres6
tools: run fetch_deps.py with Python 3
27123de 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: nodejs#48729
Fixes: nodejs#48728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@richardlau @Ceres6
tools: run fetch_deps.py with Python 3
ae4e31e 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: nodejs#48729
Fixes: nodejs#48728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
richardlau added a commit to richardlau/node-1 that referenced this pull request Aug 24, 2023
@richardlau
tools: run fetch_deps.py with Python 3
a578e6d 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: nodejs#48729
Fixes: nodejs#48728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Sep 12, 2023
@richardlau @ruyadorno
tools: run fetch_deps.py with Python 3
ab2a804 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@richardlau @ruyadorno
tools: run fetch_deps.py with Python 3
98663a9 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@ruyadorno ruyadorno mentioned this pull request Sep 13, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@richardlau @ruyadorno
tools: run fetch_deps.py with Python 3
4826379 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@MoLow MoLow MoLow approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V8 CI is broken
8 participants
@richardlau @debadree25 @nodejs-github-bot @lpinca @anonrig @targos @gengjiawen @MoLow