[v18.x] lib,src,test: lint codebase according new rules #48697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
|
Review requested:
|
nodejs-github-bot
added
c++
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
changed the title
ruyadorno
approved these changes
Jul 7, 2023
danielleadams
approved these changes
Jul 7, 2023
lpinca
approved these changes
Jul 8, 2023
MoLow
approved these changes
Jul 8, 2023
danielleadams
added
the
fast-track
|
Fast-track has been requested by @danielleadams. Please 👍 to approve. |
|
It looks like there is a hanging job - since this is a linting change and it's blocking a release (and backports), I'm going to go ahead and land. |
danielleadams
pushed a commit
that referenced
this pull request
Jul 9, 2023
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #48697 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
pushed a commit
that referenced
this pull request
Jul 9, 2023
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #48697 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
|
Landed in 2262653...a2bfe02 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v18.x-staging branch is having linting issues, creating a commit for fixing them is easier than running a rebase (the current proposal is ~500 commits)