-
-
Notifications
You must be signed in to change notification settings - Fork 32k
http: start connections checking interval on listen #48611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
ShogunPanda:http-server-check-on-listening
Jul 24, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
test/parallel/test-http-server-connections-checking-leak.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use strict'; | ||
|
||
// Flags: --expose-gc | ||
|
||
// Check that creating a server without listening does not leak resources. | ||
|
||
require('../common'); | ||
const onGC = require('../common/ongc'); | ||
ShogunPanda marked this conversation as resolved.
Show resolved
Hide resolved
|
||
const Countdown = require('../common/countdown'); | ||
|
||
const http = require('http'); | ||
const max = 100; | ||
|
||
// Note that Countdown internally calls common.mustCall, that's why it's not done here. | ||
const countdown = new Countdown(max, () => {}); | ||
ShogunPanda marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
for (let i = 0; i < max; i++) { | ||
const server = http.createServer((req, res) => {}); | ||
onGC(server, { ongc: countdown.dec.bind(countdown) }); | ||
} | ||
|
||
setImmediate(() => { | ||
global.gc(); | ||
}); |
29 changes: 29 additions & 0 deletions
29
test/parallel/test-https-server-connections-checking-leak.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
'use strict'; | ||
|
||
// Flags: --expose-gc | ||
|
||
// Check that creating a server without listening does not leak resources. | ||
|
||
const common = require('../common'); | ||
ShogunPanda marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
if (!common.hasCrypto) { | ||
common.skip('missing crypto'); | ||
} | ||
|
||
const onGC = require('../common/ongc'); | ||
const Countdown = require('../common/countdown'); | ||
|
||
const https = require('https'); | ||
const max = 100; | ||
|
||
// Note that Countdown internally calls common.mustCall, that's why it's not done here. | ||
const countdown = new Countdown(max, () => {}); | ||
|
||
for (let i = 0; i < max; i++) { | ||
const server = https.createServer((req, res) => {}); | ||
onGC(server, { ongc: countdown.dec.bind(countdown) }); | ||
} | ||
|
||
setImmediate(() => { | ||
global.gc(); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.