Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update return type for describe #48572

Merged
merged 4 commits into from
Jun 29, 2023
Merged

doc: update return type for describe #48572

merged 4 commits into from
Jun 29, 2023

Conversation

shrujalshah28
Copy link
Contributor

@shrujalshah28 shrujalshah28 commented Jun 27, 2023 •
edited by aduh95
Loading

Fixes: #48571

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jun 27, 2023
MoLow
MoLow reviewed Jun 27, 2023
View reviewed changes
doc/api/test.md Outdated Show resolved Hide resolved
@shrujalshah28 @MoLow
Update doc/api/test.md
f133380 
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
HinataKah0
HinataKah0 reviewed Jun 27, 2023
View reviewed changes
doc/api/test.md Outdated Show resolved Hide resolved
@shrujalshah28 @HinataKah0
Update doc/api/test.md
1f63560 
Co-authored-by: Shiba <128208841+HinataKah0@users.noreply.github.com>
benjamingr
benjamingr reviewed Jun 27, 2023
View reviewed changes
doc/api/test.md Outdated Show resolved Hide resolved
@shrujalshah28 @benjamingr
Update doc/api/test.md
901ece4 
Co-authored-by: Benjamin Gruenbaum <inglor@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48572
✔  Done loading data for nodejs/node/pull/48572
----------------------------------- PR info ------------------------------------
Title      doc: update return type for describe (#48572)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     shrujalshah28:fix-#48571 -> nodejs:main
Labels     doc, author ready, test_runner
Commits    4
 - doc: update return type for describe
 - Update doc/api/test.md
 - Update doc/api/test.md
 - Update doc/api/test.md
Committers 2
 - Shrujal Shah 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48572
Fixes: https://github.com/nodejs/node/issues/48571
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48572
Fixes: https://github.com/nodejs/node/issues/48571
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 27 Jun 2023 02:18:23 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48572#pullrequestreview-1501735652
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48572#pullrequestreview-1503058579
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48572
From https://github.com/nodejs/node
 * branch                  refs/pull/48572/merge -> FETCH_HEAD
✔  Fetched commits as baa5d8790f0e..901ece41efab
--------------------------------------------------------------------------------
[main a2e8580341] doc: update return type for describe
 Author: Shrujal Shah 
 Date: Tue Jun 27 02:15:23 2023 +0000
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 2a499f6753] Update doc/api/test.md
 Author: Shrujal Shah 
 Date: Tue Jun 27 10:30:19 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 22c8b07922] Update doc/api/test.md
 Author: Shrujal Shah 
 Date: Tue Jun 27 14:08:14 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 744bd25df9] Update doc/api/test.md
 Author: Shrujal Shah 
 Date: Wed Jun 28 10:35:24 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
Rebasing (2/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc: update return type for describe


PR-URL: #48572

Fixes: #48571

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com


[detached HEAD 77ee2c2f00] doc: update return type for describe

Author: Shrujal Shah shrujalshah@hotmail.com

Date: Tue Jun 27 02:15:23 2023 +0000

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (3/8)

Rebasing (4/8)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update doc/api/test.md


Co-authored-by: Moshe Atlow moshe@atlow.co.il

PR-URL: #48572

Fixes: #48571

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com


[detached HEAD ce2f91b8f6] Update doc/api/test.md

Author: Shrujal Shah shrujalshah@hotmail.com

Date: Tue Jun 27 10:30:19 2023 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (5/8)

Rebasing (6/8)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update doc/api/test.md


Co-authored-by: Shiba 128208841+HinataKah0@users.noreply.github.com

PR-URL: #48572

Fixes: #48571

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com


[detached HEAD 462a5c8904] Update doc/api/test.md

Author: Shrujal Shah shrujalshah@hotmail.com

Date: Tue Jun 27 14:08:14 2023 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (7/8)

Rebasing (8/8)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update doc/api/test.md


Co-authored-by: Benjamin Gruenbaum inglor@gmail.com

PR-URL: #48572

Fixes: #48571

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com


[detached HEAD 53785c3bd3] Update doc/api/test.md

Author: Shrujal Shah shrujalshah@hotmail.com

Date: Wed Jun 28 10:35:24 2023 +0100

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/5407865808

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit fe4ac37 into nodejs:main Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in fe4ac37

@shrujalshah28 shrujalshah28 deleted the fix-#48571 branch June 29, 2023 08:35
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@shrujalshah28 @RafaelGSS
doc: update return type for describe
cc3a056 
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@shrujalshah28 @Ceres6
doc: update return type for describe
4b340f5 
PR-URL: nodejs#48572
Fixes: nodejs#48571
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@shrujalshah28 @Ceres6
doc: update return type for describe
dcbc22a 
PR-URL: nodejs#48572
Fixes: nodejs#48571
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@shrujalshah28 @ruyadorno
doc: update return type for describe
2884705 
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ruyadorno ruyadorno mentioned this pull request Sep 11, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@shrujalshah28 @ruyadorno
doc: update return type for describe
f436ac1 
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HinataKah0 HinataKah0 HinataKah0 left review comments

@MoLow MoLow MoLow approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: wrong return type of describe
7 participants
@shrujalshah28 @nodejs-github-bot @benjamingr @lpinca @MoLow @HinataKah0 @aduh95