permission: v8.writeHeapSnapshot and process.report#48564
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Jul 4, 2023
Merged
permission: v8.writeHeapSnapshot and process.report#48564nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
c++
RafaelGSS
force-pushed
the
handle-write-report
branch
from
ec61426 to
0291784
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
RafaelGSS
force-pushed
the
handle-write-report
branch
from
0291784 to
635e2b2
Compare
github-actions
bot
removed
the
request-ci
Collaborator
36 tasks
Collaborator
joyeecheung
reviewed
Jun 28, 2023
This was referenced Jun 29, 2023
Co-Authored-By: haxatron <haxatron1@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
handle-write-report
branch
from
635e2b2 to
972c92b
Compare
RafaelGSS
commented
Jun 30, 2023
| filename = *DiagnosticFilename( | ||
| env != nullptr ? env->thread_id() : 0, "report", "json"); | ||
| } | ||
| if (env != nullptr) { |
Member
Author
There was a problem hiding this comment.
I'm not entirely sure about when the env is null. Would that happen only when OOM or another crash reporter happens? If so, what would be the best way to throw an exception here?
Maybe @gireeshpunathil has some thoughts on this?
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
This was referenced Jul 1, 2023
ShogunPanda
approved these changes
Jul 4, 2023
Contributor
ShogunPanda
left a comment
ShogunPanda
left a comment
There was a problem hiding this comment.
Other than your own comment, LGTM
marco-ippolito
approved these changes
Jul 4, 2023
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 74c2d9c |
Member
|
FWIW, the commit message does not adhere to the guidelines. |
Member
Author
What's missing? |
20 tasks
Member
|
An imperative verb after the subsystem :) |
Member
|
And in general, the commit message doesn't make much sense. It's impossible (at least for me) to understand what the commit does without looking at the diff. |
This was referenced Jul 6, 2023
juanarbol
pushed a commit
that referenced
this pull request
Jul 13, 2023
Co-Authored-By: haxatron <haxatron1@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #48564 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Co-Authored-By: haxatron <haxatron1@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#48564 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Co-Authored-By: haxatron <haxatron1@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#48564 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Member
|
@RafaelGSS corret me if I'm wrong but I don't believe the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the permission model, for now, doesn't handle other scopes than the node:fs module. Adding this validation on common write operations seems reasonable.
Co-Authored-By: @Haxatron
cc: @nodejs/security-wg