Node source

[Stevepurpose]

No description provided.

[Stevepurpose]

Would have been happier if I could learn why I am wrong by a comment to my PR

[Mesteery]

I'm very sorry, the PR confused me (no title and commits coming from another PR), which made me think it was spam.
I imagine that the previous comments came from #48109 as you used the same branch.
However, I don't understand the changes made (960e326..d37a985)
Feel free to reopen the PR.

[Stevepurpose]

Please how do I go about it,I don't think I have the permissions to do so.

[aduh95]

I think that's off-topic – this is Node.js docs, we should not document of other runtimes behavior – and also wrong (error.stack is not defined by any standard, however every JS runtime implements it).

Suggested change

However `error.stack` does not work on Microsoft,works only on Firefox .

[Stevepurpose]

Ok if that's the standard,but why studying on w3schools it was specified under JavaScript errors ,I thought it was ok mentioning it.One time I tried logging it on my pc on a project tutorial I was following band it just never logged even though it worked on the tutorial video.

[aduh95]

Suggested change

	`error.stack` property is **accessed**.
	`error.stack` property is **accessed**.

[aduh95]

Why not throw here?

[Stevepurpose]

If you were to go through the Node js docs Error class ,the section error first callbacks,talks about not throwing errors in error first callbacks,but I also noticed in the documentation it wasn't adhered to in other areas ,so I just changed a few to get a review from the maintainers ,then maybe it can be implemented all through.I think I wrote it in my commit message.

[aduh95]

OK I see where you come from, that Error-first callback section of the docs would need some work as it's quite outdated and not very clear. The important piece of information is here:

node/doc/api/errors.md

Lines 178 to 180 in 7df2758

	Throwing an error inside the callback **can crash the Node.js process** in most
	cases. If [domains][] are enabled, or a handler has been registered with
	`process.on('uncaughtException')`, such errors can be intercepted.

Crashing the process is what I would want in this case (if the operation fails, I'd expect node to exit with a non-zero exit code); how to handle the error will depend on what your use case is, and I'm not convinced we can document it better.

[Stevepurpose]

Ok,I see.

…

On Sun, 11 Jun 2023, 07:48 Antoine du Hamel, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/api/fs.md <#48357 (comment)>: > + if (err) { + console.log(err) + return + } OK I see where you come from, that Error-first callback <https://nodejs.org/api/errors.html#error-first-callbacks> section of the docs would need some work as it's quite outdated and not very clear. The important piece of information is here: https://github.com/nodejs/node/blob/7df27582bbb896ebb72697da58209976a0b4daf6/doc/api/errors.md#L178-L180 Crashing the process is what I would want in this case (if the operation fails, I'd expect node to exit with a non-zero exit code); how to handle the error will depend on what your use case is, and I'm not convinced we can document it better. — Reply to this email directly, view it on GitHub <#48357 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZDIFAI65MMWSV7VILCSZMTXKVS2ZANCNFSM6AAAAAAY4GY7PU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[avivkeller]

Hi! It's been a few months since any activity on this PR. If you wish to pursue it further, I suggest making sure it is still relevant and getting some reviews from the team.

Thanks for your contribution!

---

(CC) @nodejs/documentation

[Stevepurpose]

Thanks for the notification. I thought it has been settled by aduh95

[avivkeller]

Ping @aduh95

This PR, IMO, doesn't seem like it adds to the file, and I don't think it'll do much good being merged. WDYT?

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.