optimised runcmd func in tools/icu/icutrim.py #48241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the usage of os.system with subprocess.check_call for better security and error handling. Used a try-except block to handle CalledProcessError exceptions raised by subprocess.check_call. Return the return code of the command execution (e.returncode) when an error occurs, to allow better handling in the calling code.
nodejs-github-bot
added
i18n-api
|
Thanks for the PR! When you get a chance, please lint your commit message to abide by the guidelines we have in place. Other than that, looks good :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the usage of os.system with subprocess.check_call for better security and error handling.
Used a try-except block to handle CalledProcessError exceptions raised by subprocess.check_call.
Return the return code of the command execution (e.returncode) when an error occurs, to allow better handling in the calling code.