doc: update fs.realpath documentation #48170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
bnoordhuis
reviewed
May 27, 2023
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
Trott
added
the
commit-queue-squash
jasnell
approved these changes
May 29, 2023
aymen94
approved these changes
Jun 6, 2023
lpinca
previously approved these changes
Jun 17, 2023
lpinca
dismissed
their stale review
It does not seem to document the difference noted in #45067
|
If you have time, could you please handle this PR, thanks @bnoordhuis @lpinca @jasnell @aymen94 |
jasnell
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48170 ✔ Done loading data for nodejs/node/pull/48170 ----------------------------------- PR info ------------------------------------ Title doc: update fs.realpath documentation (#48170) Author sinkhaha <1468709106@qq.com> (@sinkhaha) Branch sinkhaha:update-doc-path-realpath -> nodejs:main Labels doc, fs, commit-queue-squash Commits 3 - doc: update fs.realpath documentation - Update doc/api/fs.md - doc: remove space Committers 2 - sinkhaha <1468709106@qq.com> - GitHub PR-URL: https://github.com/nodejs/node/pull/48170 Fixes: https://github.com/nodejs/node/issues/45067 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48170 Fixes: https://github.com/nodejs/node/issues/45067 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: remove space ℹ This PR was created on Thu, 25 May 2023 09:00:56 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/48170#pullrequestreview-1449797964 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8410404883 |
|
Landed in c4d0229 |
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#48170 Fixes: nodejs#45067 Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#48170 Fixes: nodejs#45067 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #45067