-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update outdated section on TLSv1.3-PSK #48123
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:doc-crypto-psk-sha256-outdated
May 24, 2023
Merged
doc: update outdated section on TLSv1.3-PSK #48123
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:doc-crypto-psk-sha256-outdated
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384.
Trott
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus! It gets rid of a use of "currently" which is a pet peeve of mine!
tniessen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 22, 2023
aymen94
approved these changes
May 24, 2023
lpinca
approved these changes
May 24, 2023
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 24, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 24, 2023
Landed in 817c579 |
targos
pushed a commit
that referenced
this pull request
May 30, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: #48123 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: #48123 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: nodejs#48123 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: nodejs#48123 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: nodejs#48123 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
openssl
Issues and PRs related to the OpenSSL dependency.
review wanted
PRs that need reviews.
tls
Issues and PRs related to the tls subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g.,
TLS_AES_256_GCM_SHA384
.