Skip to content

doc: correct line break for Windows terminals#48083

Merged
Trott merged 1 commit intonodejs:mainfrom
alexsch01:patch-1
May 21, 2023
Merged

doc: correct line break for Windows terminals#48083
Trott merged 1 commit intonodejs:mainfrom
alexsch01:patch-1

Conversation

@alexsch01
Copy link
Contributor

@alexsch01 alexsch01 commented May 20, 2023

Windows terminals [Command Prompt and PowerShell] don't use \ for line breaks

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 20, 2023

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 20, 2023
@Trott
Copy link
Member

Trott commented May 20, 2023

LGTM, although I wonder if we should just remove the line-wrapping entirely for these commands.

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 20, 2023
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2023
tniessen
tniessen approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows... 🤦‍♂️

sheplu
sheplu approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ovflowd
ovflowd approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@alexsch01
Copy link
Contributor Author

alexsch01 commented May 21, 2023

Can this be merged?

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label May 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2023

Fast-track has been requested by @lpinca. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2023
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 21, 2023
@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/48083
✔  Done loading data for nodejs/node/pull/48083
----------------------------------- PR info ------------------------------------
Title      doc: correct line break for Windows terminals (#48083)
Author     Alex Schwartz  (@alexsch01, first-time contributor)
Branch     alexsch01:patch-1 -> nodejs:main
Labels     doc, fast-track, author ready, commit-queue-squash
Commits    3
 - doc: correct line break for Windows terminals
 - fixup! doc: correct line break for Windows terminals
 - fixup! doc: correct line break for Windows terminals
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/48083
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Darshan Sen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Mestery 
Reviewed-By: Claudio Wunder 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48083
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Darshan Sen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Mestery 
Reviewed-By: Claudio Wunder 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 20 May 2023 00:01:20 GMT
   ✔  Approvals: 6
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435313042
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435361522
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435362880
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435449579
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435512554
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435517144
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
   ⚠  PR author is a new contributor: @alexsch01(alexschwartz01@gmail.com)
   ⚠  - commit 5452a24117c8 is authored by rtrott@gmail.com
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5038315202

@alexsch01 @Trott
doc: correct line break for Windows terminals
e49bb68 
PR-URL: #48083
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
@Trott Trott merged commit e49bb68 into nodejs:main May 21, 2023
@Trott
Copy link
Member

Trott commented May 21, 2023

Landed in e49bb68

@Trott
Copy link
Member

Trott commented May 21, 2023

Thanks for the contribution! 🎉

fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
@alexsch01 @fasenderos
doc: correct line break for Windows terminals
03bc31d 
PR-URL: nodejs#48083
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
@alexsch01 @fasenderos
doc: correct line break for Windows terminals
b943702 
PR-URL: nodejs#48083
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
targos pushed a commit that referenced this pull request May 30, 2023
@alexsch01 @targos
doc: correct line break for Windows terminals
0ac4b33 
PR-URL: #48083
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
@targos targos mentioned this pull request Jun 4, 2023
Merged
@danielleadams
Copy link
Contributor

danielleadams commented Jul 3, 2023

blocked by #47125

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@alexsch01 @Ceres6
doc: correct line break for Windows terminals
311cbd6 
PR-URL: nodejs#48083
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@alexsch01 @Ceres6
doc: correct line break for Windows terminals
abb2199 
PR-URL: nodejs#48083
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@ovflowd ovflowd ovflowd approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+2 more reviewers

@sheplu sheplu sheplu approved these changes

@Mesteery Mesteery Mesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@alexsch01 @nodejs-github-bot @Trott @danielleadams @sheplu @lpinca @tniessen @ovflowd @RaisinTen @Mesteery