-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test streambase already has a consumer #48059
Closed
MrJithil
wants to merge
1
commit into
nodejs:main
from
MrJithil:improve-webstreams-adapters-coverage
Closed
test: test streambase already has a consumer #48059
MrJithil
wants to merge
1
commit into
nodejs:main
from
MrJithil:improve-webstreams-adapters-coverage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MrJithil
commented
May 18, 2023
•
edited
Loading
edited
- test streambase already has a consumer
- newStreamDuplexFromReadableWritablePair doesn't have a readable prop
- newStreamDuplexFromReadableWritablePair doesn't have a writable prop
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
May 18, 2023
MrJithil
force-pushed
the
improve-webstreams-adapters-coverage
branch
from
May 18, 2023 13:59
ae09e10
to
d0aeccf
Compare
MrJithil
force-pushed
the
improve-webstreams-adapters-coverage
branch
from
October 7, 2023 02:03
e38084c
to
fed96f5
Compare
aduh95
reviewed
Oct 10, 2023
test/parallel/test-whatwg-webstreams-adapters-to-readablewritablepair.js
Outdated
Show resolved
Hide resolved
test/parallel/test-whatwg-webstreams-adapters-to-streamduplex.js
Outdated
Show resolved
Hide resolved
test/parallel/test-whatwg-webstreams-adapters-to-streamduplex.js
Outdated
Show resolved
Hide resolved
MrJithil
force-pushed
the
improve-webstreams-adapters-coverage
branch
from
October 11, 2023 08:59
fed96f5
to
f451c28
Compare
aduh95
reviewed
Oct 11, 2023
MrJithil
force-pushed
the
improve-webstreams-adapters-coverage
branch
from
October 11, 2023 09:21
f451c28
to
9c4697c
Compare
aduh95
approved these changes
Oct 11, 2023
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Oct 11, 2023
github-actions
bot
added
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
and removed
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Oct 11, 2023
Failed to start CInode:internal/modules/cjs/loader:1028 const err = new Error(message); ^
|
aduh95
added
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Oct 11, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Oct 28, 2023
MrJithil
force-pushed
the
improve-webstreams-adapters-coverage
branch
from
November 3, 2023 10:05
9c4697c
to
638a73b
Compare
test: test streambase has already has a consumer
MrJithil
force-pushed
the
improve-webstreams-adapters-coverage
branch
from
November 3, 2023 10:07
638a73b
to
6ade593
Compare
aduh95
approved these changes
Nov 3, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 3, 2023
This comment has been minimized.
This comment has been minimized.
14 tasks
This was referenced Nov 5, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 11, 2023
This comment has been minimized.
This comment has been minimized.
MrJithil
added a commit
that referenced
this pull request
Nov 14, 2023
test: test streambase has already has a consumer PR-URL: #48059 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in eb46e09 |
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
test: test streambase has already has a consumer PR-URL: #48059 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
test: test streambase has already has a consumer PR-URL: nodejs#48059 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
test: test streambase has already has a consumer PR-URL: #48059 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
test: test streambase has already has a consumer PR-URL: #48059 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.