Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.2.0 release proposal #48020

Merged
merged 104 commits into from
May 16, 2023
Merged

v20.2.0 release proposal #48020

merged 104 commits into from
May 16, 2023

Commits on May 5, 2023

  1. test: allow SIGBUS in signal-handler abort test

    FreeBSD uses SIGBUS after update to v12.4.
    
    Refs: nodejs/build#3134
    PR-URL: #47851
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    targos committed May 5, 2023
    Configuration menu
    Copy the full SHA
    d25c785 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. test: migrate message tests to use assertSnapshot

    PR-URL: #47498
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    34bfb69 View commit details
    Browse the repository at this point in the history
  2. tools: fix jsdoc lint

    PR-URL: #47789
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    MoLow authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7323902 View commit details
    Browse the repository at this point in the history
  3. tools: update eslint to 8.39.0

    PR-URL: #47789
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    nodejs-github-bot authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    36f7cfa View commit details
    Browse the repository at this point in the history
  4. test: fix WPT state when process exits but workers are still running

    PR-URL: #47826
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    panva authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c923367 View commit details
    Browse the repository at this point in the history
  5. doc: update BUILDING.md previous versions links

    Remove EOL release lines and add missing supported release
    lines.
    
    PR-URL: #47835
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f710676 View commit details
    Browse the repository at this point in the history
  6. doc,test: update the v8.startupSnapshot doc and test the example

    The API is now available to user-land run-time snapshots. So update
    the example. This also makes the intention of the examples a bit
    clearer and test it in our test suite.
    
    PR-URL: #47468
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    811b43c View commit details
    Browse the repository at this point in the history
  7. src: add per-isolate SetFastMethod and Set[Fast]MethodNoSideEffect

    PR-URL: #47768
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    joyeecheung authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2952cc5 View commit details
    Browse the repository at this point in the history
  8. bootstrap: log isolate data info in mksnapshot debug logs

    PR-URL: #47768
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    joyeecheung authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d6d12bf View commit details
    Browse the repository at this point in the history
  9. fs: move fs_use_promises_symbol to per-isolate symbols

    PR-URL: #47768
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    joyeecheung authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a0da234 View commit details
    Browse the repository at this point in the history
  10. bootstrap: initialize per-isolate properties of bindings separately

    This patch moves the initialization of per-isolate properties of
    the bindings that are in the embedded snapshot separate from the
    initialization of their per-context properties. This is necessary
    for workers to share the isolate snapshot with the main thread
    and deserialize these properties instead of creating them from
    scratch.
    
    PR-URL: #47768
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    joyeecheung authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    456fca0 View commit details
    Browse the repository at this point in the history
  11. src: prefer data accessor of string and vector

    The pattern of getting the address of the element at index 0 of a
    container is generally used to materialize a pointer to the backing
    data of a container, however `std::string` and `std::vector`
    provide a `data()` accessor to retrieve the data pointer which
    should be preferred.
    
    This also ensures that in the case that the container is empty, the
    data pointer access does not perform an errant memory access.
    
    PR-URL: #47750
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    VoltrexKeyva authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b04d51a View commit details
    Browse the repository at this point in the history
  12. doc: add ovflowd to collaborators

    PR-URL: #47844
    Fixes: #47672
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ovflowd authored and targos committed May 12, 2023
    4 Configuration menu
    Copy the full SHA
    c092df9 View commit details
    Browse the repository at this point in the history
  13. meta: bump codecov/codecov-action from 3.1.1 to 3.1.3

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.3.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
    - [Commits](codecov/codecov-action@d9f34f8...894ff02)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #47807
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    dependabot[bot] authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    977fd7c View commit details
    Browse the repository at this point in the history
  14. meta: bump github/codeql-action from 2.2.9 to 2.3.2

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.9 to 2.3.2.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@04df126...f3feb00)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #47809
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    dependabot[bot] authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9f06eac View commit details
    Browse the repository at this point in the history
  15. doc: replace EOL versions in README

    PR-URL: #47833
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e53e823 View commit details
    Browse the repository at this point in the history
  16. test: migrate a pseudo_tty test to use assertSnapshot

    PR-URL: #47803
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    17945a2 View commit details
    Browse the repository at this point in the history
  17. doc: add valgrind suppression details

    PR-URL: #47760
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    KevinEady authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1666a14 View commit details
    Browse the repository at this point in the history
  18. worker: use snapshot in workers spawned by workers

    Previously we didn't pass the snapshot data down to the isolate
    data of workers so workers spawned by workers won't use the
    snapshot. Fixes it by passing the snapshot data down.
    
    PR-URL: #47731
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    6f3876c View commit details
    Browse the repository at this point in the history
  19. path: indicate index of wrong resolve() parameter

    PR-URL: #47660
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    sosoba authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7222f9d View commit details
    Browse the repository at this point in the history
  20. sea: allow requiring core modules with the "node:" prefix

    Previously, the `require()` function exposed to the embedded SEA code
    was calling the internal `require()` function if the module name
    belonged to the list of public core modules but the internal `require()`
    function does not support loading modules with the "node:" prefix, so
    this change forwards the calls to another `require()` function that
    supports this.
    
    Fixes: nodejs/single-executable#69
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #47779
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    RaisinTen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1a7fc18 View commit details
    Browse the repository at this point in the history
  21. sea: add option to disable the experimental SEA warning

    Refs: nodejs/single-executable#60
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #47588
    Fixes: #47741
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    RaisinTen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c4596b9 View commit details
    Browse the repository at this point in the history
  22. src: get binding data store directly from the realm

    We now store the binding data store in the realm and invoke
    `Realm::AddBindingData` to add the binding data, so there is no
    need to get a reference to the binding data store from the context
    now, we can just get the reference from the realm.
    
    PR-URL: #47437
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d358317 View commit details
    Browse the repository at this point in the history
  23. quic: address recent coverity warning

    Address coverity warning about uninitialized value
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    PR-URL: #47753
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1625ae1 View commit details
    Browse the repository at this point in the history
  24. src: avoid strcmp() with Utf8Value

    Having Utf8Value::operator==() without operator!=() is awkward in C++17,
    so add the negated equality operator. Then, use either instead of
    strcmp() where appropriate.
    
    PR-URL: #47827
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    4bc17fd View commit details
    Browse the repository at this point in the history
  25. src: fix creating an ArrayBuffer from a Blob created with openAsBlob

    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #47691
    Fixes: #47683
    Reviewed-By: James M Snell <jasnell@gmail.com>
    daeyeon authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c421761 View commit details
    Browse the repository at this point in the history
  26. module: block requiring test/reporters without scheme

    PR-URL: #47831
    Fixes: #47828
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    MoLow authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    739113f View commit details
    Browse the repository at this point in the history
  27. test: reduce WPT concurrency

    PR-URL: #47834
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    panva authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    54607bf View commit details
    Browse the repository at this point in the history
  28. http2: improve nghttp2 error callback

    The http2 implementation uses the deprecated function
    nghttp2_session_callbacks_set_error_callback, which does not supply an
    error code but only an error message. This so far forced node's error
    callback to rely on the error message in order to distinguish between
    different errors, which is fragile and inefficient.
    
    Use the newer nghttp2_session_callbacks_set_error_callback2 function
    instead, which is not deprecated and which provides the exact error code
    to node's error callback.
    
    PR-URL: #47840
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    tniessen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a4d6543 View commit details
    Browse the repository at this point in the history
  29. node-api: get Node API version used by addon

    PR-URL: #45715
    Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    vmoroz authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f489c67 View commit details
    Browse the repository at this point in the history
  30. test: fix output tests when path includes node version

    PR-URL: #47843
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    30f4f35 View commit details
    Browse the repository at this point in the history
  31. doc: swap Matteo with Rafael in the stewards

    PR-URL: #47841
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    RafaelGSS authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f96fb2e View commit details
    Browse the repository at this point in the history
  32. doc: add stability experimental to pm

    PR-URL: #47890
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    RafaelGSS authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    89c70dc View commit details
    Browse the repository at this point in the history
  33. deps: update ada to 2.3.1

    PR-URL: #47893
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d23b1af View commit details
    Browse the repository at this point in the history
  34. doc: update supported version of FreeBSD to 12.4

    Refs: nodejs/build#3134
    PR-URL: #47838
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9a362aa View commit details
    Browse the repository at this point in the history
  35. doc: fix params names

    PR-URL: #47853
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Semigradsky authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    93f1aa2 View commit details
    Browse the repository at this point in the history
  36. crypto: remove default encoding from pbkdf2

    Refs: #47182
    PR-URL: #47869
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e9c6ee7 View commit details
    Browse the repository at this point in the history
  37. src: clarify the parameter name in Permission::Apply

    This fixes confusing parameter names. They are references
    to set allow-permission.
    
    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #47874
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    daeyeon authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    515c9b8 View commit details
    Browse the repository at this point in the history
  38. doc: improve permission.has description

    This fixes the function description and adds missing available scopes.
    
    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #47875
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    daeyeon authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    4dfc389 View commit details
    Browse the repository at this point in the history
  39. deps: upgrade npm to 9.6.6

    PR-URL: #47862
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luke Karrys <luke@lukekarrys.com>
    npm-cli-bot authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7b2f17c View commit details
    Browse the repository at this point in the history
  40. test: fix webcrypto wrap unwrap tests

    Refs: #47864
    PR-URL: #47876
    Refs: #47864
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    panva authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7e34f77 View commit details
    Browse the repository at this point in the history
  41. crypto: fix webcrypto private/secret import with empty usages

    Refs: #47864
    PR-URL: #47877
    Refs: #47864
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    panva authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    09fb74a View commit details
    Browse the repository at this point in the history
  42. test: use appropriate usages for a negative import test

    Refs: #47864
    PR-URL: #47878
    Refs: #47864
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    panva authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8f547af View commit details
    Browse the repository at this point in the history
  43. meta: remove extra space in scorecard workflow

    This extra space is preventing dependabot from replacing the old version
    by the new one, on dependencies/actions update.
    
    PR-URL: #47805
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Mesteery authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    652b06d View commit details
    Browse the repository at this point in the history
  44. meta: bump actions/checkout from 3.3.0 to 3.5.2

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.5.2.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@v3.3.0...8e5e7e5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    PR-URL: #47805
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    dependabot[bot] authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0f58e48 View commit details
    Browse the repository at this point in the history
  45. meta: bump actions/setup-python from 4.5.0 to 4.6.0

    Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.5.0 to 4.6.0.
    - [Release notes](https://github.com/actions/setup-python/releases)
    - [Commits](actions/setup-python@d27e3f3...57ded4d)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-python
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #47806
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    dependabot[bot] authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f7a8094 View commit details
    Browse the repository at this point in the history
  46. meta: bump step-security/harden-runner from 2.2.1 to 2.3.1

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.2.1 to 2.3.1.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@1f99358...6b3083a)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #47808
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    dependabot[bot] authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    6c158e8 View commit details
    Browse the repository at this point in the history
  47. deps: V8: cherry-pick 1b471b796022

    Original commit message:
    
        [riscv] Using s8 as backtrack_stackpointer reg and optimize BranchShortHelper
    
        1. Fix incorrect backtrack_stackpointer reg.
        2. Optimize BranchShortHelper when comparing zero immediate.
        3. This is a workaround CL fix v8:13836
    
        Bug: v8:13836
    
        Change-Id: I4cfc9df92fcd38ecd448a41ee87d1e251efd4ad9
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394942
        Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
        Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
        Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
        Cr-Commit-Position: refs/heads/main@{#86889}
    
    Refs: v8/v8@1b471b7
    PR-URL: #47399
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    luyahan authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    cad42e7 View commit details
    Browse the repository at this point in the history
  48. src: stop copying code cache

    The code cache is quite large - around 1.3 MiB. Change the code to use
    non-owning buffers to avoid copying it. For starting up an otherwise
    empty main isolate, this saves around 1.3 MiB of unique set size memory
    (9.9 MiB -> 8.6 MiB) and 1.1ms elapsed time (22.9 ms -> 21.8 ms).
    
    Copying the code cache is unnecessary since:
    
    1. for the builtin snapshot, the code cache data has static lifetime.
    2. for non-builtin snapshots, we create copies of the code cache data in
       `SnapshotDeserializer::ReadVector`. These copies are owned by the
       `Environment` (through `IsolateData` -> `SnapshotData`), so they
       won't be deallocated.
    3. a worker thread can copy a parent's isolate's code cache, but in that
       case we still know that the parent isolate will outlive the worker
       isolate.
    
    (Admittedly point (2) feels a little fragile from a lifetime
    perspective, and I would be happy to restrict this optimization to the
    builtin snapshot.)
    
    ```console
    $ perf stat -r 100 -e ... ./node -e 0
    
     Performance counter stats for './node -e 0' (100 runs):
    
                 21.78 msec task-clock
                  2760      page-faults
             113161604      instructions
              18437648      branches
                423230      branch-misses
                853093      cache-references
                 41474      cache-misses
    
             0.0225473 +- 0.0000504 seconds time elapsed  ( +-  0.22% )
    
    $ perf stat -r 100 -e ... ./node-main -e 0
    
     Performance counter stats for './node-main -e 0' (100 runs):
    
                 22.91 msec task-clock
                  3102      page-faults
             114890673      instructions
              18751329      branches
                428909      branch-misses
                895721      cache-references
                 45202      cache-misses
    
             0.0233760 +- 0.0000741 seconds time elapsed  ( +-  0.32% )
    ```
    
    PR-URL: #47144
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    kvakil authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a11507e View commit details
    Browse the repository at this point in the history
  49. url: improve isURL detection

    PR-URL: #47886
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1b06c1e View commit details
    Browse the repository at this point in the history
  50. buffer: combine checking range of sourceStart in buf.copy

    Merging 2 checking range of sourceStart into 1. Plus,
    add test case to increase coverage if sourceStart is greater
    than length of source.
    
    PR-URL: #47758
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    deokjinkim authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e457d89 View commit details
    Browse the repository at this point in the history
  51. dgram: convert macro to template

    It's not pretty either way, but a template is still preferable over a
    macro.
    
    PR-URL: #47891
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    tniessen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    72340c9 View commit details
    Browse the repository at this point in the history
  52. src: register ext reference for Fingerprint512

    Refs: #39809
    Refs: #40239
    PR-URL: #47892
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    tniessen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9bc5d78 View commit details
    Browse the repository at this point in the history
  53. child_process: use signal.reason in child process abort

    Fixes: #47814
    PR-URL: #47817
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    debadree25 authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    00668fc View commit details
    Browse the repository at this point in the history
  54. module: refactor to use normalizeRequirableId in the CJS module loader

    `BuiltinModule.normalizeRequirableId()` was introduced in
    #47779 to fix a bug in the require
    function of SEAs and Snapshots, so that built-in modules with the
    `node:` scheme could be required correctly. This change makes more use
    of this API instead of `BuiltinModule.canBeRequiredByUsers()` and
    `BuiltinModule.canBeRequiredWithoutScheme()` to reduce chances of
    such bugs.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #47896
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    RaisinTen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c19385c View commit details
    Browse the repository at this point in the history
  55. tools: update eslint to 8.40.0

    PR-URL: #47906
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e22c686 View commit details
    Browse the repository at this point in the history
  56. src: support V8 experimental shared values in messaging

    PR-URL: #47706
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    syg authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    4293cc4 View commit details
    Browse the repository at this point in the history
  57. doc: ntfs junction points must link to directories

    Fixes: #40184
    PR-URL: #47907
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    bnoordhuis authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bf39f2d View commit details
    Browse the repository at this point in the history
  58. tools: update lint-md-dependencies to rollup@3.21.5

    PR-URL: #47903
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    706c305 View commit details
    Browse the repository at this point in the history
  59. deps: update ada to 2.4.0

    PR-URL: #47922
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    nodejs-github-bot authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c2b14b4 View commit details
    Browse the repository at this point in the history
  60. doc: mark global object as legacy

    PR-URL: #47819
    Fixes: #47784
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    mertcanaltin authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7ed99e8 View commit details
    Browse the repository at this point in the history
  61. tools: automate icu-small update

    PR-URL: #47727
    Refs: nodejs/security-wg#828
    Reviewed-By: Steven R Loomis <srl295@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    marco-ippolito authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f6ff318 View commit details
    Browse the repository at this point in the history
  62. doc: document make lint-md-clean

    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    PR-URL: #47926
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mcollina authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c9ffc55 View commit details
    Browse the repository at this point in the history
  63. fs: make readdir recursive algorithm iterative

    PR-URL: #47650
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Ethan Arrowood authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    106dc61 View commit details
    Browse the repository at this point in the history
  64. src: register external references for source code

    Currently we use external strings for internalized builtin source code.
    However when a snapshot is taken, any external string whose resource
    is not registered is flattened into a SeqString (see ref). The
    result is that module source code stored in the snapshot does not
    use external strings after deserialization. This patch registers an
    external string resource for each internalized builtin's source. The
    savings are substantial: ~1.9 MB of heap memory per isolate, or ~44%
    of an otherwise empty isolate's heap usage:
    
    ```console
    $ node --expose-gc -p 'gc(),process.memoryUsage().heapUsed'
    4190968
    $ ./node --expose-gc -p 'gc(),process.memoryUsage().heapUsed'
    2327536
    ```
    
    The savings can be even higher for user snapshots which may include
    more internal modules.
    
    The existing UnionBytes implementation was ill-suited, because it only
    created an external string resource when ToStringChecked was called,
    but we need to register the external string resources before the
    isolate even exists. We change UnionBytes to no longer own the data,
    and shift ownership of the data to a new external resource class
    called StaticExternalByteResource.  StaticExternalByteResource are
    either statically allocated (for internalized builtin code) or owned
    by the static `externalized_builtin_sources` map, so they will only be
    destructed when static resources are destructed. We change JS2C to emit
    statements to register a string resource for each internalized builtin.
    
    Refs: https://github.com/v8/v8/blob/d2c8fbe9ccd1a6ce5591bb7dd319c3c00d6bf489/src/snapshot/serializer.cc#L633
    PR-URL: #47055
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    kvakil authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    190596c View commit details
    Browse the repository at this point in the history
  65. deps: V8: cherry-pick a8a11a87cb72

    Original commit message:
    
        [wasm] Simplify CompileJSToWasmWrapperJob
    
        This CL merges some of AsyncCompileJSToWasmWrapperJob and
        CompileJSToWasmWrapperJob into a common base class. Both jobs now
        loop on a vector with an atomic index.
    
        Bug: chromium:1423615
        Change-Id: I7bb9cb2a57d8b659766c01e20e38d1b859d3a987
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4347597
        Reviewed-by: Clemens Backes <clemensb@chromium.org>
        Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#86675}
    
    Refs: v8/v8@a8a11a8
    PR-URL: #47610
    Refs: #47297
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    99f8fca View commit details
    Browse the repository at this point in the history
  66. deps: V8: cherry-pick 5f025d1ca2ca

    Original commit message:
    
        [wasm] Fix deadlock in async wrapper compilation
    
        If compilation is cancelled while wrapper compilation is running, the
        tasks spawned for the {AsyncCompileJSToWasmWrapperJob} will return
        immediately, but {GetMaxConcurrency} will still return a positive
        value. Hence {Join()} will spawn another task, resulting in a
        livelock.
    
        We could fix this by checking for cancellation in {GetMaxConcurrency},
        but that requires taking the compilation state lock.
        So this CL fixes the issue by dropping the number of outstanding
        compilation units by to (basically) zero. We can't unconditionally drop
        to zero because another thread might concurrently execute a wrapper
        compilation and still call {CompleteUnit} afterwards. Hence only drop
        outstanding units by the amount of not-yet-started units.
    
        R=jkummerow@chromium.org
    
        Bug: v8:13858
        Change-Id: I5398ef370da2e7f212ca772fd1f87f659929dd6d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4437531
        Commit-Queue: Clemens Backes <clemensb@chromium.org>
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#87143}
    
    Refs: v8/v8@5f025d1
    PR-URL: #47610
    Refs: #47297
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b16f6da View commit details
    Browse the repository at this point in the history
  67. src: rename SKIP_CHECK_SIZE to SKIP_CHECK_STRLEN

    SKIP_CHECK_VALUE is a string literal, so its size is the length of the
    string in chars plus one. The buffer buf is also always null-terminated,
    so its size should match the size of SKIP_CHECK_VALUE, which is _not_
    SKIP_CHECK_SIZE.
    
    Rename SKIP_CHECK_SIZE to be consistent with C/C++ terminology.
    
    PR-URL: #47845
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
    tniessen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bd553e7 View commit details
    Browse the repository at this point in the history
  68. test_runner: omit inaccessible files from coverage

    If V8 generates code coverage for a file that is later
    inaccessible to the test runner, then omit that file from the
    coverage report.
    
    PR-URL: #47850
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    cjihrig authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d81c54e View commit details
    Browse the repository at this point in the history
  69. dns: call ada::idna::to_ascii directly from c++

    PR-URL: #47920
    Fixes: nodejs/performance#77
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    anonrig authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9be9228 View commit details
    Browse the repository at this point in the history
  70. test,crypto: update WebCryptoAPI WPT

    PR-URL: #47921
    Refs: #47864
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    panva authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    aa2c7e0 View commit details
    Browse the repository at this point in the history
  71. test_runner: fix ordering of test hooks

    For tests with subtests the before hook was being run after the
    beforeEach hook, which is the opposite to test suites and expectations.
    
    Also, a function was being used to close over the after hooks, but at
    the point it was being run the after hooks were not yet set up.
    
    Fixes #47915
    
    PR-URL: #47931
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    philnash authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    42db1d5 View commit details
    Browse the repository at this point in the history
  72. src: move BlobSerializerDeserializer to a separate header file

    This should make it possible to reuse the BlobSerializer and the
    BlobDeserializer classes in SEAs to generate and parse the injected
    blob.
    
    This change also resolves this TODO:
    https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187
    
    Refs: #47458
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #47933
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    RaisinTen authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0c06bfd View commit details
    Browse the repository at this point in the history
  73. permission: resolve reference to absolute path only for fs permission

    For other candidate permissions, such as "net" or "env", this patch
    will pass the reference without resolving it to an absolute path.
    
    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #47930
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    daeyeon authored and targos committed May 12, 2023
    Configuration menu
    Copy the full SHA
    af86625 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. meta: add security-wg ping to permission.js

    PR-URL: #47941
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RafaelGSS authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    2a3d6d9 View commit details
    Browse the repository at this point in the history
  2. doc: remove broken link

    Closes: #47940
    PR-URL: #47942
    Fixes: #47940
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    6f5ba92 View commit details
    Browse the repository at this point in the history
  3. crypto: remove default encoding from scrypt

    Refs: #47182
    PR-URL: #47943
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    d799347 View commit details
    Browse the repository at this point in the history
  4. test: unskip negative-settimeout.any.js WPT

    PR-URL: #47946
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    panva authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    6e01958 View commit details
    Browse the repository at this point in the history
  5. lib: update comment

    Rename NODE_MODULE_CONTEXT_AWARE_CPP to NODE_BINDING_CONTEXT_AWARE_CPP.
    
    PR-URL: #47884
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sinkhaha authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    a4fed6c View commit details
    Browse the repository at this point in the history
  6. worker: support more cases when (de)serializing errors

    - error.cause is potentially an error, so is now handled recursively
    - best effort to serialize thrown symbols
    - handle thrown object with custom inspect
    
    PR-URL: #47925
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    47fea13 View commit details
    Browse the repository at this point in the history
  7. doc: fix broken link

    PR-URL: #47953
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b9771c9 View commit details
    Browse the repository at this point in the history
  8. test: add getRandomValues return length

    PR-URL: #46357
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    MrJithil authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    bb33c74 View commit details
    Browse the repository at this point in the history
  9. doc: fix broken link to TC39 import attributes proposal

    The import assertion proposal has been renamed and
    the old URL does not redirect to the new one. So let's update our
    URL to point to the import attributes proposal, which is what
    import assertions have been renamed to.
    
    PR-URL: #47954
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7ecc674 View commit details
    Browse the repository at this point in the history
  10. vm,lib: refactor microtaskQueue assignment logic

    Simplify the assignment of the `microtaskQueue` variable in the `vm`
    module by replacing the conditional block with a more concise ternary
    operator. This change improves code readability and maintainability.
    
    PR-URL: #47765
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    XadillaX authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    e6685f9 View commit details
    Browse the repository at this point in the history
  11. http: prevent writing to the body when not allowed by HTTP spec

    PR-URL: #47732
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    gerrard00 authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4197a9a View commit details
    Browse the repository at this point in the history
  12. doc: update measure memory rejection information

    If in case context is unable to allocate a promise then
    `ERR_CONTEXT_NOT_INITIALIZED` error will be thrown (as promise
    rejection) in the vm measureMemory call.
    
    PR-URL: #41639
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    yashLadha authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    3727964 View commit details
    Browse the repository at this point in the history
  13. meta: bump actions/setup-python from 4.5.0 to 4.6.0

    Sync with other files updated in dca352a.
    
    PR-URL: #47968
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    c05c0a2 View commit details
    Browse the repository at this point in the history
  14. doc: update description of global

    With widespread support for ES modules, the description of global is
    outdated now.
    
    PR-URL: #47969
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    13118a1 View commit details
    Browse the repository at this point in the history
  15. esm: do not use 'beforeExit' on the main thread

    PR-URL: #47964
    Fixes: #47929
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    aduh95 authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    1ec640a View commit details
    Browse the repository at this point in the history
  16. src: add cjs_module_lexer_version base64_version

    src: add cjs_module_lexer_version base64_version
    PR-URL: #45629
    Refs: #45260
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MrJithil authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    1aec718 View commit details
    Browse the repository at this point in the history
  17. url: add value argument to has and delete methods

    The change aims to add value argument to two methods of URLSearchParams
    class i.e the has method and the delete method. For has method, if
    value argument is provided, then use it to check for presence. For
    delete method, if value argument provided, use it to delete.
    
    Fixes: #47883
    PR-URL: #47885
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    sankalp1999 authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    a0634d7 View commit details
    Browse the repository at this point in the history
  18. tools: debug log for nghttp3

    PR-URL: #47992
    Refs: #47576
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    marco-ippolito authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    a4e261e View commit details
    Browse the repository at this point in the history
  19. meta: bump github/codeql-action from 2.3.2 to 2.3.3

    PR-URL: #47979
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    f5b4b6d View commit details
    Browse the repository at this point in the history
  20. meta: bump step-security/harden-runner from 2.3.1 to 2.4.0

    PR-URL: #47980
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Trott authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    fd8bec7 View commit details
    Browse the repository at this point in the history
  21. doc: add missing deprecated blocks to cluster

    I believe that these are required so that the respective APIs are
    marked as deprecated in the table of contents.
    
    PR-URL: #47981
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    tniessen authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4a1e971 View commit details
    Browse the repository at this point in the history
  22. deps: update simdutf to 3.2.9

    PR-URL: #47983
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    nodejs-github-bot authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b7f13a8 View commit details
    Browse the repository at this point in the history
  23. src: stop copying code cache, part 2

    This removes more copies of the code cache data.
    
    First: for the builtin snapshot, we were copying the code cache to
    create a `std::vector<uint8_t>`. This was slowing down static
    intialization. Change it to use a good old `uint8_t*` and `size_t`
    rather than a vector. For the case of embedder provided snapshots, we
    also add an `owning_ptr` so that we can properly cleanup owned values
    created from the snapshot.
    
    Second: whenever the code cache was hit, we would remove the bytecode
    from the code cache, and then reserialize it from the compiled function.
    This was pretty slow. Change the code so that we can reuse the same code
    cache multiple times. If the code cache is rejected (say, because the
    user added V8 options), then we need to generate the bytecode, in which
    case we again use `owning_ptr` to ensure that the underlying code cache
    is freed.
    
    Combined, these changes improve the misc/startup.js benchmarks
    significantly (p < 0.001):
    
    * process,benchmark/fixtures/require-builtins: 22.15%
    * process,test/fixtures/semicolon: 8.55%
    * worker,benchmark/fixtures/require-builtins: 26.52%
    * worker,test/fixtures/semicolon: 21.52%
    
    PR-URL: #47958
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    kvakil authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    060c1d5 View commit details
    Browse the repository at this point in the history
  24. test_runner: add shorthands to test

    PR-URL: #47909
    Fixes: #47897
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    atlowChemi authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    17befe0 View commit details
    Browse the repository at this point in the history
  25. vm: fix crash when setting __proto__ on context's globalThis

    PR-URL: #47939
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    F3n67u authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    2bd869d View commit details
    Browse the repository at this point in the history
  26. test: mark test-esm-loader-http-imports as flaky

    This test has been failing occasionally for weeks.
    
    Refs: #47836
    Refs: nodejs/reliability#564
    PR-URL: #47987
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    tniessen authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    010d2ec View commit details
    Browse the repository at this point in the history
  27. src: deduplicate X509Certificate::Fingerprint*

    All three functions do the same, except using different cryptographic
    hash functions. Move the common logic into a new template and use it
    directly.
    
    PR-URL: #47978
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    786a1c5 View commit details
    Browse the repository at this point in the history
  28. permission: remove unused function declaration

    RestrictAccess() is declared, but it's not used.
    
    PR-URL: #47957
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    deokjinkim authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7dd32f1 View commit details
    Browse the repository at this point in the history
  29. test_runner: use v8.serialize instead of TAP

    PR-URL: #47867
    Fixes: #44656
    Fixes: #47955
    Fixes: #47481
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    da27542 View commit details
    Browse the repository at this point in the history
  30. 2023-05-16, Version 20.2.0 (Current)

    Notable changes:
    
    doc:
      * add ovflowd to collaborators (Claudio Wunder) #47844
    http:
      * (SEMVER-MINOR) prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732
    sea:
      * (SEMVER-MINOR) add option to disable the experimental SEA warning (Darshan Sen) #47588
    test_runner:
      * (SEMVER-MINOR) add `skip`, `todo`, and `only` shorthands to `test` (Chemi Atlow) #47909
    url:
      * (SEMVER-MINOR) add value argument to `URLSearchParams` `has` and `delete` methods (Sankalp Shubham) #47885
    
    PR-URL: #48020
    targos committed May 15, 2023
    Configuration menu
    Copy the full SHA
    258e9e7 View commit details
    Browse the repository at this point in the history