Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix params names #47853

Merged
merged 2 commits into from
May 6, 2023
Merged

doc: Fix params names #47853

merged 2 commits into from
May 6, 2023

Conversation

Semigradsky
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels May 4, 2023
@Semigradsky Semigradsky changed the title Fix params names doc: Fix params names May 4, 2023
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 6, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47853
✔  Done loading data for nodejs/node/pull/47853
----------------------------------- PR info ------------------------------------
Title      doc: Fix params names (#47853)
Author     Dmitry Semigradsky  (@Semigradsky)
Branch     Semigradsky:patch-2 -> nodejs:main
Labels     doc, stream, author ready
Commits    2
 - doc: fix params names
 - doc: capitalize the first characters
Committers 1
 - Dmitry Semigradsky 
PR-URL: https://github.com/nodejs/node/pull/47853
Reviewed-By: Luigi Pinca 
Reviewed-By: Harshitha K P 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47853
Reviewed-By: Luigi Pinca 
Reviewed-By: Harshitha K P 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 04 May 2023 09:20:04 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47853#pullrequestreview-1413833963
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/47853#pullrequestreview-1414637380
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 47853
From https://github.com/nodejs/node
 * branch                  refs/pull/47853/merge -> FETCH_HEAD
✔  Fetched commits as 351bf775e169..c98a66aec052
--------------------------------------------------------------------------------
[main dbf132fa20] doc: fix params names
 Author: Dmitry Semigradsky 
 Date: Thu May 4 18:10:33 2023 +0300
 1 file changed, 3 insertions(+), 3 deletions(-)
[main a8abd4e801] doc: capitalize the first characters
 Author: Dmitry Semigradsky 
 Date: Thu May 4 18:12:05 2023 +0300
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: fix params names

PR-URL: #47853
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Harshitha K P harshitha014@gmail.com

[detached HEAD e179c7d87f] doc: fix params names
Author: Dmitry Semigradsky semigradskyd@gmail.com
Date: Thu May 4 18:10:33 2023 +0300
1 file changed, 3 insertions(+), 3 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: capitalize the first characters

PR-URL: #47853
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Harshitha K P harshitha014@gmail.com

[detached HEAD bbe9a52c77] doc: capitalize the first characters
Author: Dmitry Semigradsky semigradskyd@gmail.com
Date: Thu May 4 18:12:05 2023 +0300
1 file changed, 3 insertions(+), 3 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4903281450

@debadree25 debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit 281ef80 into nodejs:main May 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 281ef80

targos pushed a commit that referenced this pull request May 12, 2023
PR-URL: #47853
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47853
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47853
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants