-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fix params names #47853
doc: Fix params names #47853
Conversation
Commit Queue failed- Loading data for nodejs/node/pull/47853 ✔ Done loading data for nodejs/node/pull/47853 ----------------------------------- PR info ------------------------------------ Title doc: Fix params names (#47853) Author Dmitry Semigradsky (@Semigradsky) Branch Semigradsky:patch-2 -> nodejs:main Labels doc, stream, author ready Commits 2 - doc: fix params names - doc: capitalize the first characters Committers 1 - Dmitry Semigradsky PR-URL: https://github.com/nodejs/node/pull/47853 Reviewed-By: Luigi Pinca Reviewed-By: Harshitha K P ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47853 Reviewed-By: Luigi Pinca Reviewed-By: Harshitha K P -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 04 May 2023 09:20:04 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47853#pullrequestreview-1413833963 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/47853#pullrequestreview-1414637380 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47853 From https://github.com/nodejs/node * branch refs/pull/47853/merge -> FETCH_HEAD ✔ Fetched commits as 351bf775e169..c98a66aec052 -------------------------------------------------------------------------------- [main dbf132fa20] doc: fix params names Author: Dmitry Semigradsky Date: Thu May 4 18:10:33 2023 +0300 1 file changed, 3 insertions(+), 3 deletions(-) [main a8abd4e801] doc: capitalize the first characters Author: Dmitry Semigradsky Date: Thu May 4 18:12:05 2023 +0300 1 file changed, 3 insertions(+), 3 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4903281450 |
Landed in 281ef80 |
PR-URL: #47853 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
PR-URL: #47853 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
PR-URL: nodejs#47853 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
No description provided.