Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix suite signal #47800

Merged
merged 7 commits into from
May 17, 2023
Merged

test: fix suite signal #47800

merged 7 commits into from
May 17, 2023

Conversation

benjamingr
Copy link
Member

@benjamingr benjamingr commented May 1, 2023 •
edited by MoLow
Loading

Fixes: #47882
@MoLow that's the bug about the suite not getting the AbortSignal correctly.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 1, 2023
@benjamingr benjamingr marked this pull request as ready for review May 1, 2023 12:37
@MoLow
Copy link
Member

MoLow commented May 1, 2023

still has some linting issues

@benjamingr
Copy link
Member Author

That's fine I have a week (bad case) or 48h (best case) to fix it, presumably ^^

aduh95
aduh95 reviewed May 2, 2023
View reviewed changes
lib/internal/test_runner/test.js Outdated Show resolved Hide resolved
lib/internal/test_runner/test.js Outdated Show resolved Hide resolved
@benjamingr @aduh95
Update lib/internal/test_runner/test.js
9f38158 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow
Copy link
Member

MoLow commented May 5, 2023

ping @benjamingr

@MoLow
Copy link
Member

MoLow commented May 15, 2023

@benjamingr should I complete this PR?

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51835/

@MoLow MoLow requested a review from aduh95 May 16, 2023 20:35
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51844/

@MoLow MoLow requested a review from cjihrig May 17, 2023 05:31
@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2023
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3cf05be into nodejs:main May 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 3cf05be

@github-actions github-actions bot mentioned this pull request May 23, 2023
Open
22 tasks
targos pushed a commit that referenced this pull request May 30, 2023
@benjamingr @targos
test: fix suite signal
a80dd3a 
PR-URL: #47800
Fixes: #47882
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@benjamingr @danielleadams
test: fix suite signal
d6076b9 
PR-URL: #47800
Fixes: #47882
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@benjamingr @MoLow
test: fix suite signal
7b816b4 
PR-URL: nodejs#47800
Fixes: nodejs#47882
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@MoLow MoLow MoLow approved these changes

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig Awaiting requested review from cjihrig

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[node:test] Incorrect SuiteContext description
6 participants
@benjamingr @nodejs-github-bot @MoLow @ljharb @aduh95 @targos