tools: move update-npm to dep updaters

[marco-ippolito]

Move update-npm to correct folder
It could actually be deleted because people from npm take care of the update (for reference: https://github.com/npm/cli/blob/latest/.github/workflows/create-node-pr.yml) with npm-cli-bot but I'm leaving it in case a manual update is needed

[Trott]

This breaks the script because the script makes assumptions about what directory it is in. You'll need to update the line that sets BASE_DIR so that DEPS_DIR will be set correctly.

[Trott]

Oops, just noticed that this script and its path are mentioned in doc/contributing/maintaining-npm.md so we'll want to update that too. Might be worth having a look to see if material in that file needs to be replaced if this script isn't actually being used anymore.

[Trott]

This script doesn't work. It runs make but cli has no Makefile. We might want to remove the script entirely or ask @nodejs/npm for recommendations on how to get it working again.

[wraithgar]

imho the way npm was updated into node was pretty overwrought. The existing npm can be used to find the new npm. Absent that the url can be automatically built if the npm version is known. Everything from the git clone to the make release can be replaced with the fetching of a single url:

$ curl -s $(npm view npm@$NPM_VERSION dist.tarball) > npm.tgz
$ rm rf npm
$ mkdir npm
$ tar zxvf npm.tgz --strip-component=1 -C npm

That's it. The published npm package does not have any further build steps. It is necessarily self-contained because otherwise we'd have no way to bootstrap it.

I'll let @lukekarrys weigh in too since I know he's thought a lot about this recently.

[wraithgar]

This script, if fixed, is a nice backup to the existing process but as of today the PR to update npm is a single one-liner part of npm's release process. It also makes a PR that's a full diff between the existing version in Node.js against the newest, with a changelog. We're happy to keep the current process if it's working for y'all.

[marco-ippolito]

My intention was to keep it as a backup so I'll fix the script

[marco-ippolito]

@wraithgar PTAL

Issue is addressed

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/47619
✔  Done loading data for nodejs/node/pull/47619
----------------------------------- PR info ------------------------------------
Title      tools: move update-npm to dep updaters (#47619)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/automate-npm -> nodejs:main
Labels     tools, commit-queue-squash
Commits    3
 - tools: move update-npm to dep updaters
 - fix: update base dir
 - fix: npm update file
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/47619
Reviewed-By: Luigi Pinca 
Reviewed-By: Paolo Insogna 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47619
Reviewed-By: Luigi Pinca 
Reviewed-By: Paolo Insogna 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - fix: npm update file
   ℹ  This PR was created on Wed, 19 Apr 2023 12:17:08 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47619#pullrequestreview-1392754676
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47619#pullrequestreview-1395770782
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4806468899

[nodejs-github-bot]

Landed in e2e3f5c