Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix updating root certificates #47607

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

richardlau
Copy link
Member

When searching for the latest certdata.txt, check that the file exists on the remote server.

Refs: #47597 (comment)

When searching for the latest certdata.txt, check that the file
exists on the remote server.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 18, 2023
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 472ffde into nodejs:main Apr 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 472ffde

@richardlau richardlau deleted the rootcerts branch April 21, 2023 02:50
targos pushed a commit that referenced this pull request May 2, 2023
When searching for the latest certdata.txt, check that the file
exists on the remote server.

PR-URL: #47607
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
When searching for the latest certdata.txt, check that the file
exists on the remote server.

PR-URL: #47607
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
When searching for the latest certdata.txt, check that the file
exists on the remote server.

PR-URL: nodejs#47607
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants