-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-api: test passing NULL to napi_define_class #47567
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
gabrielschulhof:pass-null-to-napi_define_class
Apr 26, 2023
Merged
node-api: test passing NULL to napi_define_class #47567
nodejs-github-bot
merged 1 commit into
nodejs:main
from
gabrielschulhof:pass-null-to-napi_define_class
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
node-api
Issues and PRs related to the Node-API.
test
Issues and PRs related to the tests.
labels
Apr 15, 2023
This was referenced Apr 24, 2023
mhdawson
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 25, 2023
36 tasks
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 26, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 26, 2023
Landed in 11f97d4 |
35 tasks
29 tasks
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47567 Reviewed-By: Michael Dawson <midawson@redhat.com>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47567 Reviewed-By: Michael Dawson <midawson@redhat.com>
32 tasks
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 29, 2023
PR-URL: nodejs#47567 Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Apr 30, 2023
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47567 Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47567 Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47567 Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.