Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-api: test passing NULL to napi_define_class #47567

Merged

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Apr 15, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2023
@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit 11f97d4 into nodejs:main Apr 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 11f97d4

yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos mentioned this pull request May 2, 2023
@gabrielschulhof gabrielschulhof deleted the pass-null-to-napi_define_class branch May 20, 2023 01:05
@gabrielschulhof gabrielschulhof restored the pass-null-to-napi_define_class branch May 20, 2023 14:41
@gabrielschulhof gabrielschulhof deleted the pass-null-to-napi_define_class branch June 3, 2023 18:10
@gabrielschulhof gabrielschulhof restored the pass-null-to-napi_define_class branch June 5, 2023 02:21
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants