Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: test passing NULL to number APIs #47549

Merged
merged 1 commit into from
Apr 20, 2023
Merged

node-api: test passing NULL to number APIs #47549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/js-native-api/test_number/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
{
"target_name": "test_number",
"sources": [
"../common.c",
"../entry_point.c",
"test_number.c"
"test_number.c",
"test_null.c",
]
}
]
Expand Down
77 changes: 77 additions & 0 deletions test/js-native-api/test_number/test_null.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
#include <js_native_api.h>

#include "../common.h"

// Unifies the way the macros declare values.
typedef double double_t;

#define BINDING_FOR_CREATE(initial_capital, lowercase) \
static napi_value Create##initial_capital(napi_env env, \
napi_callback_info info) { \
napi_value return_value, call_result; \
lowercase##_t value = 42; \
NODE_API_CALL(env, napi_create_object(env, &return_value)); \
add_returned_status(env, \
"envIsNull", \
return_value, \
"Invalid argument", \
napi_invalid_arg, \
napi_create_##lowercase(NULL, value, &call_result)); \
napi_create_##lowercase(env, value, NULL); \
add_last_status(env, "resultIsNull", return_value); \
return return_value; \
}

#define BINDING_FOR_GET_VALUE(initial_capital, lowercase) \
static napi_value GetValue##initial_capital(napi_env env, \
napi_callback_info info) { \
napi_value return_value, call_result; \
lowercase##_t value = 42; \
NODE_API_CALL(env, napi_create_object(env, &return_value)); \
NODE_API_CALL(env, napi_create_##lowercase(env, value, &call_result)); \
add_returned_status( \
env, \
"envIsNull", \
return_value, \
"Invalid argument", \
napi_invalid_arg, \
napi_get_value_##lowercase(NULL, call_result, &value)); \
napi_get_value_##lowercase(env, NULL, &value); \
add_last_status(env, "valueIsNull", return_value); \
napi_get_value_##lowercase(env, call_result, NULL); \
add_last_status(env, "resultIsNull", return_value); \
return return_value; \
}

BINDING_FOR_CREATE(Double, double)
BINDING_FOR_CREATE(Int32, int32)
BINDING_FOR_CREATE(Uint32, uint32)
BINDING_FOR_CREATE(Int64, int64)
BINDING_FOR_GET_VALUE(Double, double)
BINDING_FOR_GET_VALUE(Int32, int32)
BINDING_FOR_GET_VALUE(Uint32, uint32)
BINDING_FOR_GET_VALUE(Int64, int64)

void init_test_null(napi_env env, napi_value exports) {
const napi_property_descriptor test_null_props[] = {
DECLARE_NODE_API_PROPERTY("createDouble", CreateDouble),
DECLARE_NODE_API_PROPERTY("createInt32", CreateInt32),
DECLARE_NODE_API_PROPERTY("createUint32", CreateUint32),
DECLARE_NODE_API_PROPERTY("createInt64", CreateInt64),
DECLARE_NODE_API_PROPERTY("getValueDouble", GetValueDouble),
DECLARE_NODE_API_PROPERTY("getValueInt32", GetValueInt32),
DECLARE_NODE_API_PROPERTY("getValueUint32", GetValueUint32),
DECLARE_NODE_API_PROPERTY("getValueInt64", GetValueInt64),
};
napi_value test_null;

NODE_API_CALL_RETURN_VOID(env, napi_create_object(env, &test_null));
NODE_API_CALL_RETURN_VOID(
env,
napi_define_properties(env,
test_null,
sizeof(test_null_props) / sizeof(*test_null_props),
test_null_props));
NODE_API_CALL_RETURN_VOID(
env, napi_set_named_property(env, exports, "testNull", test_null));
}
8 changes: 8 additions & 0 deletions test/js-native-api/test_number/test_null.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#ifndef TEST_JS_NATIVE_API_TEST_NUMBER_TEST_NULL_H_
#define TEST_JS_NATIVE_API_TEST_NUMBER_TEST_NULL_H_

#include <js_native_api.h>

void init_test_null(napi_env env, napi_value exports);

#endif // TEST_JS_NATIVE_API_TEST_NUMBER_TEST_NULL_H_
18 changes: 18 additions & 0 deletions test/js-native-api/test_number/test_null.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';
const common = require('../../common');
const assert = require('assert');
const { testNull } = require(`./build/${common.buildType}/test_number`);

const expectedCreateResult = {
envIsNull: 'Invalid argument',
resultIsNull: 'Invalid argument',
};
const expectedGetValueResult = {
envIsNull: 'Invalid argument',
resultIsNull: 'Invalid argument',
valueIsNull: 'Invalid argument',
};
[ 'Double', 'Int32', 'Uint32', 'Int64' ].forEach((typeName) => {
assert.deepStrictEqual(testNull['create' + typeName](), expectedCreateResult);
assert.deepStrictEqual(testNull['getValue' + typeName](), expectedGetValueResult);
});
3 changes: 3 additions & 0 deletions test/js-native-api/test_number/test_number.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include <js_native_api.h>
#include "../common.h"
#include "test_null.h"

static napi_value Test(napi_env env, napi_callback_info info) {
size_t argc = 1;
Expand Down Expand Up @@ -101,6 +102,8 @@ napi_value Init(napi_env env, napi_value exports) {
NODE_API_CALL(env, napi_define_properties(
env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));

init_test_null(env, exports);

return exports;
}
EXTERN_C_END