-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add mailmap entry for KhafraDev #47512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make `git log` entries for KhafraDev show up using the name in the README, which is required so that find-inactive-collaborators.mjs doesn't incorrectly flag him for removal.
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Apr 11, 2023
Fast-track has been requested by @Trott. Please 👍 to approve. |
panva
approved these changes
Apr 11, 2023
KhafraDev
approved these changes
Apr 11, 2023
anonrig
approved these changes
Apr 11, 2023
debadree25
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 11, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 11, 2023
Landed in b318f84 |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
This will make `git log` entries for KhafraDev show up using the name in the README, which is required so that find-inactive-collaborators.mjs doesn't incorrectly flag him for removal. PR-URL: #47512 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
This will make `git log` entries for KhafraDev show up using the name in the README, which is required so that find-inactive-collaborators.mjs doesn't incorrectly flag him for removal. PR-URL: #47512 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This will make `git log` entries for KhafraDev show up using the name in the README, which is required so that find-inactive-collaborators.mjs doesn't incorrectly flag him for removal. PR-URL: nodejs#47512 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make
git log
entries for KhafraDev show up using the name in the README, which is required so that find-inactive-collaborators.mjs doesn't incorrectly flag him for removal.