Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] lib: fix trailing commas and leftover function from rebasing #47503

Closed
wants to merge 1 commit into from
Closed

[v18.x] lib: fix trailing commas and leftover function from rebasing #47503

wants to merge 1 commit into from

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Apr 11, 2023 •
edited
Loading

Fixes remaining linting errors and a leftover function from rebasing #47502.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 11, 2023
@danielleadams danielleadams removed timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. whatwg-url Issues and PRs related to the WHATWG URL implementation. needs-ci PRs that need a full CI run. labels Apr 11, 2023
danielleadams added a commit that referenced this pull request Apr 11, 2023
@danielleadams
lib: fix trailing commas and leftover function from rebasing
62cbddd 
PR-URL: #47503
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@danielleadams
Copy link
Contributor Author

Landed in 62cbddd

@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielleadams @nodejs-github-bot @aduh95 @RafaelGSS