src: get binding data store directly from the realm #47437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
legendecas
approved these changes
Apr 6, 2023
jasnell
approved these changes
Apr 10, 2023
31 tasks
36 tasks
This was referenced Apr 25, 2023
|
This conflicts with the main branch now. |
35 tasks
We now store the binding data store in the realm and invoke `Realm::AddBindingData` to add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm.
joyeecheung
force-pushed
the
binding-map
branch
from
377a2bd
to
60c49c3
Compare
|
Oops, I did a rebase some time ago and I forgot to push. |
29 tasks
legendecas
added
the
author ready
This was referenced Apr 29, 2023
This was referenced May 2, 2023
joyeecheung
added a commit
that referenced
this pull request
May 4, 2023
We now store the binding data store in the realm and invoke `Realm::AddBindingData` to add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm. PR-URL: #47437 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landedin 27467a8 |
targos
pushed a commit
that referenced
this pull request
May 12, 2023
We now store the binding data store in the realm and invoke `Realm::AddBindingData` to add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm. PR-URL: #47437 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
added
the
backport-requested-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now store the binding data store in the realm and invoke
Realm::AddBindingDatato add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm.